add, remove recipients #72
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -460,3 +509,4 @@ def get_template(self, templateId): | |||
| .format(accountId=self.account_id, | |||
| templateId=templateId) | |||
| return self.get(url) | |||
|
|
|||
|
Nice work ! Is it possible to add some tests ? |
| data = { | ||
| 'signers': [{'recipientId': x} for x in recipientIds] | ||
| } | ||
| return self.delete(url, data=data) |
There was a problem hiding this comment.
A simple test would be to check all that formatting:
def test_delete_envelope...(self):
client = ...
with patch('DocusignClient.delete') as delete:
client.delete_enveleop_recipients(...)This way we have coverage of this unit of code. The integration with docusign process is another test strategy that could be done with in-house integration plateform.
|
@smcoll I planned to release the 1.0 in few days, do you want to change something on this PR, or at least rebase it on master, just to be sure ? |
|
closed in favor of #93 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a proposal for #70. i wish that the
add_envelope_recipientshortcut would return a JSON object for the one recipient, but given the way DocuSign returns a response of all recipient types, i thought that might get a little wonky.