Add Kenyan calendar #484
Merged
Add Kenyan calendar #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KidkArolis
commented
Apr 15, 2020
| (12, 31, "New Years Eve"), | ||
| ) | ||
|
|
||
| def get_fixed_holidays(self, year): |
There was a problem hiding this comment.
Added this to dynamically introduce 'Moi Memorial Day' in 2020 and to rename some things based on year.
KidkArolis
commented
Apr 15, 2020
|
|
||
| return days | ||
|
|
||
| def get_shifted_holidays(self, dates): |
There was a problem hiding this comment.
Added these next two methods to shift Sundays to Mondays, but I've excluded the Islamic days from being shifted.
|
Fixed the linting. |
brunobord
requested changes
Apr 17, 2020
| (12, 31, "New Years Eve"), | ||
| ) | ||
|
|
||
| def get_fixed_holidays(self, year): |
|
|
||
| return days | ||
|
|
||
| def get_shifted_holidays(self, dates): |
|
Amended |
brunobord
approved these changes
Apr 17, 2020
brunobord
added a commit
that referenced
this pull request
Apr 17, 2020
**New Calendar** - Added Kenyan calendar, by @KidkArolis (#484) **Minor fixes** - Fixed Lithuania calendar to use the core flags for Assumption and All Saints (#468). - Fixed Malta calendar ; January 1st was already included, no need to add it to the ``FIXED_HOLIDAYS`` property (#469). - Small refactor in Netherlands calendar to use core constants (#470).
|
The latest workalendar release (8.4.0) now integrates your Kenyan calendar. Happy upgrading! https://pypi.org/project/workalendar/8.4.0/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
workalendar.registry_tools.iso_registerdecorator to register your new calendar using ISO codes (optional).<country>by@pseudo(#)".