Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lithuania uses Assumption day and all saints as FIXED_DAYS #468

Closed
brunobord opened this issue Feb 21, 2020 · 0 comments · Fixed by #486
Closed

Lithuania uses Assumption day and all saints as FIXED_DAYS #468

brunobord opened this issue Feb 21, 2020 · 0 comments · Fixed by #486
Labels
small improvement Small steps, but nice to have
Projects
Workalendar

Comments

@brunobord
Copy link
Member

brunobord commented Feb 21, 2020 •
edited

They should rather use the flags.
@brunobord brunobord added the bug label Feb 21, 2020
@brunobord brunobord changed the title Assumption day (August 15th) is sometimes in the FIXED days Lithuania uses Assumption day and all saints as FIXED_DAYS Feb 21, 2020
@brunobord brunobord added small improvement Small steps, but nice to have and removed bug labels Feb 21, 2020
brunobord added a commit that referenced this issue Apr 17, 2020
@brunobord
Fixed Lithuania calender to use the core flags for Assumption and All…
67feaab 
… Saints

closes #468
@brunobord brunobord mentioned this issue Apr 17, 2020
Merged
2 tasks
@brunobord brunobord added this to Warming up in Workalendar via automation Apr 17, 2020
@brunobord brunobord moved this from Warming up to Working in Workalendar Apr 17, 2020
Workalendar automation moved this from Working to Done Apr 17, 2020
brunobord added a commit that referenced this issue Apr 17, 2020
@brunobord
v8.4.0
3c00cf9 
**New Calendar**

- Added Kenyan calendar, by @KidkArolis (#484)

**Minor fixes**

- Fixed Lithuania calendar to use the core flags for Assumption and All Saints (#468).
- Fixed Malta calendar ; January 1st was already included, no need to add it to the ``FIXED_HOLIDAYS`` property (#469).
- Small refactor in Netherlands calendar to use core constants (#470).
@brunobord brunobord mentioned this issue Apr 17, 2020
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
small improvement Small steps, but nice to have
Projects
Workalendar
  
Done/Closed/Published
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed Lithuania calender to use the core flags for Assumption and All Saints workalendar/workalendar
1 participant
@brunobord