Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use configs to drive language resources #12

Merged
merged 2 commits into from Dec 9, 2015
Merged

Use configs to drive language resources #12

merged 2 commits into from Dec 9, 2015

Conversation

eponvert
Copy link
Contributor

@eponvert eponvert commented Dec 8, 2015

Note, this comes with a breaking change! Instead of

val bundle = LangBundle.en

you now go:

val bundle = LangBundle("en")

The string implicits still work.

@eponvert
Copy link
Contributor Author

eponvert commented Dec 9, 2015

SERIOUSLY, Coveralls?

@eponvert
Copy link
Contributor Author

eponvert commented Dec 9, 2015

OK all the checks are green. 💯

@jfrazee
Copy link

jfrazee commented Dec 9, 2015

👍

@eponvert eponvert merged commit f3665ea into master Dec 9, 2015
eponvert added a commit that referenced this pull request Dec 9, 2015
@eponvert
Accept PR #12
7a95250
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eponvert @jfrazee