Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP8Speaks doesn't honor pycodestyle ignores #133

Closed
thealphadollar opened this issue Jun 13, 2019 · 2 comments
Closed

PEP8Speaks doesn't honor pycodestyle ignores #133

thealphadollar opened this issue Jun 13, 2019 · 2 comments

Comments

@thealphadollar
Copy link

At sample-platform we recently added migrations and for the same we added ignore parameter to PEP8Speaks.yml but PEP8Speaks did not honor the ignore parameter in the same way as pycodestyle.

Below is the configuration for both; PEP8Speaks and pycodestlye.

Screenshot from 2019-06-13 17-37-30

We use pycodestyle in our build tests and they pass which means the ignore is honored by it.

Though PEP8SPeaks doesn't ignore the migrations directory and gives a lot of errors.

@thealphadollar
Copy link
Author

Probably due to #130

@OrkoHunter Please confirm and close 😄 I'll work on this on behalf of @CCExtractor.

@thealphadollar
Copy link
Author

thealphadollar commented Jun 13, 2019

The issue is indeed the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant