Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not fail if expected list config is of NoneType #120

Merged
merged 2 commits into from Mar 16, 2019

Conversation

OrkoHunter
Copy link
Collaborator

https://github.com/SwagLyrics/SwagLyrics-For-Spotify/blob/456a5cfae242ca8f7a28a3d849a062b61e9f478c/.pep8speaks.yml#L7-L10

flake8:  # Same as scanner.linter value. Other option is flake8
    max-line-length: 120  # Default is 79 in PEP 8
    ignore:  # Errors and warnings to ignore

flake8.ignore is supposed to be a list. A config like this in yaml, produces a NoneType and results in error.

Thank you @aadibajpai for raising the issue!

@auto-comment
Copy link

auto-comment bot commented Mar 16, 2019

💖 Thank you so much for creating the pull request! 💖

Have a look at the test workflow. The branch of this pull request is going to be deployed on Heroku with payload URL https://pep8speaks-pr-xxx.herokuapp.com . The repository https://github.com/OrkoHunter/test-pep8speaks is configured to test review deployments like this.

@OrkoHunter Create a review app for this PR on Heroku and update the Webhook URL of the test-pep8speaks app. Finally restart Travis to test this PR.
Remember to redeploy the production app and revert the Webhook URL when the Pull Request is merged.

@OrkoHunter OrkoHunter temporarily deployed to pep8speaks-pr-120 March 16, 2019 06:08 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant