Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependency updates #103

Merged
merged 9 commits into from
Mar 28, 2018
Merged

dependency updates #103

merged 9 commits into from
Mar 28, 2018

Conversation

antonkulaga
Copy link
Contributor

I updated major dependencies to newer versions because they blocked me in my projects.

Copy link
Owner

@pepegar pepegar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @antonkulaga , thank you very much for this!

The docs are failing to build because of change in Contextual.

I think that a change in the implementation of the interpolator to this would make them work:

  object UriInterpolator extends Interpolator {
    type Output = Uri
    type ContextType = UriContext.type
    type Input = String
    def contextualize(interpolation: StaticInterpolation) = {
      interpolation.parts.foldLeft(List.empty[ContextType]) {
        case (contexts, Hole(_, _)) => UriContext :: contexts
        case (contexts, _) => contexts
      }
    }

    def evaluate(interpolation: RuntimeInterpolation): Uri =
      Uri.fromString(interpolation.literals.head).right.get
  }

Also, added a small comment regarding sbt version.

@@ -1 +1 @@
sbt.version=1.0.4
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you downgraded SBT without meaning it :)

@pepegar
Copy link
Owner

pepegar commented Mar 28, 2018

Hey @antonkulaga , I fixed the errors, once the build passes I'll merge and then deploy

@codecov
Copy link

codecov bot commented Mar 28, 2018

Codecov Report

Merging #103 into master will decrease coverage by 0.26%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #103      +/-   ##
==========================================
- Coverage   69.52%   69.26%   -0.27%     
==========================================
  Files          22       22              
  Lines         617      615       -2     
  Branches        8        6       -2     
==========================================
- Hits          429      426       -3     
- Misses        188      189       +1
Impacted Files Coverage Δ
...a-http/src/main/scala/hammock/akka/implicits.scala 0% <ø> (ø) ⬆️
core/shared/src/main/scala/hammock/package.scala 16.66% <50%> (-11.91%) ⬇️
core/shared/src/main/scala/hammock/Uri.scala 96.1% <0%> (-1.3%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d44ff3...dcaeafb. Read the comment docs.

@pepegar pepegar merged commit b95a63d into pepegar:master Mar 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants