-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dependency updates #103
dependency updates #103
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @antonkulaga , thank you very much for this!
The docs are failing to build because of change in Contextual.
I think that a change in the implementation of the interpolator to this would make them work:
object UriInterpolator extends Interpolator {
type Output = Uri
type ContextType = UriContext.type
type Input = String
def contextualize(interpolation: StaticInterpolation) = {
interpolation.parts.foldLeft(List.empty[ContextType]) {
case (contexts, Hole(_, _)) => UriContext :: contexts
case (contexts, _) => contexts
}
}
def evaluate(interpolation: RuntimeInterpolation): Uri =
Uri.fromString(interpolation.literals.head).right.get
}
Also, added a small comment regarding sbt version.
project/build.properties
Outdated
@@ -1 +1 @@ | |||
sbt.version=1.0.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you downgraded SBT without meaning it :)
I think it's better to have this plugin as a global SBT plugin, if you like
Hey @antonkulaga , I fixed the errors, once the build passes I'll merge and then deploy |
Codecov Report
@@ Coverage Diff @@
## master #103 +/- ##
==========================================
- Coverage 69.52% 69.26% -0.27%
==========================================
Files 22 22
Lines 617 615 -2
Branches 8 6 -2
==========================================
- Hits 429 426 -3
- Misses 188 189 +1
Continue to review full report at Codecov.
|
I updated major dependencies to newer versions because they blocked me in my projects.