Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#111 Added methods to Status #112

Merged

Conversation

IIVat
Copy link
Contributor

@IIVat IIVat commented Jun 24, 2018

Status was enriched with methods, which allow to check the status codes of a response shortly.
#111

@codecov
Copy link

codecov bot commented Jun 24, 2018

Codecov Report

Merging #112 into master will increase coverage by 0.24%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #112      +/-   ##
==========================================
+ Coverage   68.99%   69.24%   +0.24%     
==========================================
  Files          22       22              
  Lines         629      634       +5     
  Branches       10        8       -2     
==========================================
+ Hits          434      439       +5     
  Misses        195      195
Impacted Files Coverage Δ
core/shared/src/main/scala/hammock/Status.scala 99.27% <100%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da4f172...2029741. Read the comment docs.

@pepegar
Copy link
Owner

pepegar commented Jun 25, 2018

Hey @IIVat , thank you very much for your contribution, good idea.

Do you think you can add some tests for this?

Cheers ;)

@IIVat
Copy link
Contributor Author

IIVat commented Jun 25, 2018

Hey @pepegar. Sure, will be done.

@pepegar
Copy link
Owner

pepegar commented Jul 2, 2018

LGTM! Thanks @IIVat !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants