Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrects incorrect header name used in basic authentication #118

Merged
merged 1 commit into from Sep 6, 2018

Conversation

pandemonium
Copy link
Contributor

I reported the bug. Please accept my attempt at fixing it.

@codecov
Copy link

codecov bot commented Sep 6, 2018

Codecov Report

Merging #118 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #118   +/-   ##
======================================
  Coverage    69.4%   69.4%           
======================================
  Files          22      22           
  Lines         634     634           
  Branches        9       9           
======================================
  Hits          440     440           
  Misses        194     194
Impacted Files Coverage Δ
core/shared/src/main/scala/hammock/Hammock.scala 71.42% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a7e0fe...f84a5c9. Read the comment docs.

@pepegar
Copy link
Owner

pepegar commented Sep 6, 2018

Hey @pandemonium, thank you very much for both the bug report & the fix!

@pepegar pepegar merged commit 63ade86 into pepegar:master Sep 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants