Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separated Apache HTTP Client from core #156

Merged
merged 8 commits into from
Jan 17, 2019
Merged

Separated Apache HTTP Client from core #156

merged 8 commits into from
Jan 17, 2019

Conversation

mhriemers
Copy link
Contributor

See issue #130

@miciek
Copy link
Collaborator

miciek commented Jan 11, 2019

Thanks @ipsq I think we should also update the README to include this change as well.

@pepegar
Copy link
Owner

pepegar commented Jan 13, 2019

Hey @ipsq ! this is awesome, thank you very much!

The error in the build is because I changed the release process in #151 and changed build.sbt. Can you update your PR with master as well?

After having the build passing, and updating the README I think we'll be able to merge :)

@mhriemers
Copy link
Contributor Author

@miciek Updated the README. Let me know what you think.

@pepegar Build should be passing now.

Copy link
Owner

@pepegar pepegar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to make the docs project depend on apache as well... you can test that the docs project builds correctly with:

sbt docs/tut

README.md Outdated Show resolved Hide resolved
@mhriemers
Copy link
Contributor Author

Only just realized I was editing the wrong README. Build should pass.

@codecov
Copy link

codecov bot commented Jan 17, 2019

Codecov Report

Merging #156 into master will decrease coverage by 2.57%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #156      +/-   ##
==========================================
- Coverage   69.76%   67.19%   -2.58%     
==========================================
  Files          22       21       -1     
  Lines         635      570      -65     
  Branches        9        2       -7     
==========================================
- Hits          443      383      -60     
+ Misses        192      187       -5
Impacted Files Coverage Δ
...e/shared/src/main/scala/hammock/HttpResponse.scala 0% <0%> (-100%) ⬇️
core/shared/src/main/scala/hammock/Entity.scala 18.18% <0%> (-13.64%) ⬇️
core/shared/src/main/scala/hammock/Status.scala 98.55% <0%> (-0.73%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a38b2b2...2b23cde. Read the comment docs.

@pepegar
Copy link
Owner

pepegar commented Jan 17, 2019

This is awesome @ipsq great job, thank you very much!

@pepegar pepegar merged commit af7aee5 into pepegar:master Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants