-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separated Apache HTTP Client from core #156
Conversation
Thanks @ipsq I think we should also update the README to include this change as well. |
…-api-impl # Conflicts: # build.sbt
…code back to the jvm package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to make the docs
project depend on apache
as well... you can test that the docs project builds correctly with:
sbt docs/tut
Only just realized I was editing the wrong README. Build should pass. |
Codecov Report
@@ Coverage Diff @@
## master #156 +/- ##
==========================================
- Coverage 69.76% 67.19% -2.58%
==========================================
Files 22 21 -1
Lines 635 570 -65
Branches 9 2 -7
==========================================
- Hits 443 383 -60
+ Misses 192 187 -5
Continue to review full report at Codecov.
|
This is awesome @ipsq great job, thank you very much! |
See issue #130