Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix js client #92

Merged
merged 1 commit into from
Jan 17, 2018
Merged

fix js client #92

merged 1 commit into from
Jan 17, 2018

Conversation

pepegar
Copy link
Owner

@pepegar pepegar commented Jan 17, 2018

This PR fixes 2 different bugs:

  1. exampleJS project was failing to link because cats-effect wasn't included for JS (it used %% instead of %%%)
  2. MatchError when parsing empty headers from XHR response.

fixes #91 and #90

@codecov
Copy link

codecov bot commented Jan 17, 2018

Codecov Report

Merging #92 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #92   +/-   ##
=======================================
  Coverage   65.11%   65.11%           
=======================================
  Files          22       22           
  Lines         579      579           
  Branches       10       10           
=======================================
  Hits          377      377           
  Misses        202      202

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 129bfd3...0793ba0. Read the comment docs.

@pepegar
Copy link
Owner Author

pepegar commented Jan 17, 2018

Ignoring Codacy for now, since most of the issues are style related and code style is not aligned with what we use here.

@pepegar pepegar merged commit c791987 into master Jan 17, 2018
@pepegar pepegar deleted the fix-js-client branch January 17, 2018 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hammock scalajs does not work
1 participant