Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create functions to log into DATIM #5

Merged
merged 1 commit into from
Sep 13, 2019
Merged

Create functions to log into DATIM #5

merged 1 commit into from
Sep 13, 2019

Conversation

jacksonsj
Copy link
Collaborator

No description provided.

@jacksonsj jacksonsj self-assigned this Sep 11, 2019
@sam-bao
Copy link
Collaborator

sam-bao commented Sep 12, 2019

@jason-p-pickering @jacksonsj Should we be making us of the keyring for login passwords in some way?

https://cran.r-project.org/web/packages/keyring/keyring.pdf

@sam-bao
Copy link
Collaborator

sam-bao commented Sep 13, 2019

@jason-p-pickering recording details from our slack conversation here:

Logins functions should

  1. Accept a config file with no slash, a slash, or multiple slashes for baseurl and mutate this to a single trailing slash
  2. All other API calls in code, should never start with a slash
  3. A utility function to a) encode all URIs and b) check if there are any double slashes (which we know will fail)
  • e.g. a wrapper around utils::urlencode that thrown an error if there is a "//" other than in "https://"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants