Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build "edit" page #24

Closed
tomzemp opened this issue Sep 9, 2019 · 3 comments
Closed

Build "edit" page #24

tomzemp opened this issue Sep 9, 2019 · 3 comments
Assignees

Comments

@tomzemp
Copy link
Contributor

tomzemp commented Sep 9, 2019

Work on building page for this:
image

-Convert map properties to Chip "Headers" in side bar (with handlers for add/delete)
-In main space, have parsed questionnaire with links to map's headers/properties
-For initial stage, probably have question use a select of the available headers/properties from the map
-api calls to back-end to update map as user makes changes

@tomzemp tomzemp self-assigned this Sep 9, 2019
@tomzemp
Copy link
Contributor Author

tomzemp commented Sep 9, 2019

Need to decide how to handle this...trying to pass map/parsed questionnaire as props from UpdateMap component, which redirects based on whether you are in edit/upload mode. However, passing props to be used as state is a bit buggy (https://reactjs.org/blog/2018/06/07/you-probably-dont-need-derived-state.html) and seems not to work as well as the older 16.3 and earlier version of componentWillReceiveProps...could redo to retrieve map/parse within the specific edit/upload

tomzemp pushed a commit that referenced this issue Sep 10, 2019
@tomzemp
Copy link
Contributor Author

tomzemp commented Sep 10, 2019

Decided to pull map/questionnaire set state at lower level component to get around issue mentioned above (#24 (comment)) ... considered Redux but probably not necessary, code can be reused as service within MapUpload and MapEdit components, but could probably be improved further

tomzemp pushed a commit that referenced this issue Sep 10, 2019
@tomzemp
Copy link
Contributor Author

tomzemp commented Sep 10, 2019

Next steps:

  • build handler on selects (i.e. need to update map based on what is selected (and set value on select))
  • check names of new headers for "validity"
  • push back update map to back end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant