Generate open-graph images for blog posts #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepicrft
commented
May 21, 2023
| @@ -1 +1,3 @@ | |||
| use "nix" | |||
| export ERL_AFLAGS="-kernel shell_history enabled -kernel shell_history_file_bytes 1024000" | |||
There was a problem hiding this comment.
I added this one to preserve the shell history across the runs of IEx.
pepicrft
commented
May 21, 2023
| {:ok, %{watcher_pid: watcher_pid}} | ||
| end | ||
|
|
||
| def handle_info({:file_event, watcher_pid, {path, events}}, %{watcher_pid: watcher_pid} = state) do |
There was a problem hiding this comment.
This function is not being called at all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
All the routes in this website have the same static image as an open graph image. I'd like to make it more dynamic based on the content of the URL being shared.
What
I'm adding dynamic open-graph generation for the blog posts in the website. The way I'm approaching the problem is by:
mix phx.gen.open_graph, that runs as part of deployment to generate the images for all the blog posts.