Improve site footer #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The standard style for links established by the hugo-PaperMod theme used by the website is for the text to be underlined. That style was somehow lost when a custom footer was implemented for the site. It is hereby restored. The approach used to obtain the underline comes from the theme's CSS code: https://github.com/adityatelange/hugo-PaperMod/blob/v7.0/assets/css/common/footer.css#L26
I think it looks better with a margin on each side.
Previously a crude approach was taken to graphically separating the footer components. A superior approach is to use borders. This gives more control over the appearance which allows achieving an aesthetically superior design.
This will make it easier for visitors who are interested in the source code of the project to find the GitHub repository.
The default footer height set by the hugo-PaperMod theme is far larger than necessary, which is unsightly in addition to wasting page space.
per1234
added
type: enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.