Make USE_VALGRIND default OFF and fix includes for valgrind headers #73
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BUG:
https://bugs.launchpad.net/percona-server/+bug/1494283
This is basically just for start of work because it needs more discussion.
Purpose:
It's default OFF in PerconaFT and here seems it was ON because valgrind includes are not optional.
Questionable thing:
I see that in most places VALGRIND_HG_DISABLE_CHECKING is used, but in backup_debug.cc TOKUBACKUP_VALGRIND_HG_DISABLE_CHECKING is used.
Maybe we should change that one to VALGRIND_HG_DISABLE_CHECKING also and remove define for the TOKUBACKUP_VALGRIND_HG_DISABLE_CHECKING one?