Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make USE_VALGRIND default OFF and fix includes for valgrind headers #73

Merged
merged 1 commit into from Sep 17, 2015
Merged

Make USE_VALGRIND default OFF and fix includes for valgrind headers #73

merged 1 commit into from Sep 17, 2015

Conversation

tplavcic
Copy link
Member

BUG:
https://bugs.launchpad.net/percona-server/+bug/1494283

This is basically just for start of work because it needs more discussion.

Purpose:

  1. Make USE_VALGRIND default to OFF from TokuBackup
    It's default OFF in PerconaFT and here seems it was ON because valgrind includes are not optional.
  2. Use backup_helgrind.h since it's already there

Questionable thing:
I see that in most places VALGRIND_HG_DISABLE_CHECKING is used, but in backup_debug.cc TOKUBACKUP_VALGRIND_HG_DISABLE_CHECKING is used.
Maybe we should change that one to VALGRIND_HG_DISABLE_CHECKING also and remove define for the TOKUBACKUP_VALGRIND_HG_DISABLE_CHECKING one?

@tplavcic
Copy link
Member Author

@georgelorchpercona
I also had discussion about should we maybe rename that USE_VALGRIND to WITH_VALGRIND (which is used in PS) with Laurynas but since this is only a submodule for PS and we're not sure where is it used in other products we concluded maybe not to change this for now.

@george-lorch
Copy link
Contributor

No problem changing to WITH_VALGRIND but we should probably scour all of the former tokudb-engine and tokudb-backup-plugin code now within Percona Server and PerconaFT and Percona-TokuBackup projects, clean them all at once so we don't end up with some odd mix.

@george-lorch
Copy link
Contributor

On changing VALGRIND_HG_DISABLE_CHECKING to TOKUBACKUP_VALGRIND_HG_DISABLE_CHECKING, I would prefer actually to go the other way. This gives us easier way to change the macro behavior since it is now our own macro to define/redefine.

george-lorch pushed a commit that referenced this pull request Sep 17, 2015
Make USE_VALGRIND default OFF and fix includes for valgrind headers
@george-lorch george-lorch merged commit de7c66d into percona:master Sep 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants