Skip to content

Commit

Permalink
fixed some invalid parameter passing discovered by clang Tokutek/mong…
Browse files Browse the repository at this point in the history
…o#869

TXNID_NONE is not the same as (TOKUTXN) 0
  • Loading branch information
leifwalsh committed Dec 24, 2013
1 parent 46804fa commit 650f0e1
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion ft/tests/ftloader-test-bad-generate.cc
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ static void test_extractor(int nrows, int nrowsets, bool expect_fail) {
}

FTLOADER loader;
r = toku_ft_loader_open(&loader, NULL, generate, NULL, N, brts, dbs, fnames, compares, "tempXXXXXX", ZERO_LSN, TXNID_NONE, true, 0, false);
r = toku_ft_loader_open(&loader, NULL, generate, NULL, N, brts, dbs, fnames, compares, "tempXXXXXX", ZERO_LSN, nullptr, true, 0, false);
assert(r == 0);

struct rowset *rowset[nrowsets];
Expand Down
2 changes: 1 addition & 1 deletion ft/tests/ftloader-test-extractor-errors.cc
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ static void test_extractor(int nrows, int nrowsets, bool expect_fail, const char
sprintf(temp, "%s/%s", testdir, "tempXXXXXX");

FTLOADER loader;
r = toku_ft_loader_open(&loader, NULL, generate, NULL, N, brts, dbs, fnames, compares, "tempXXXXXX", ZERO_LSN, TXNID_NONE, true, 0, false);
r = toku_ft_loader_open(&loader, NULL, generate, NULL, N, brts, dbs, fnames, compares, "tempXXXXXX", ZERO_LSN, nullptr, true, 0, false);
assert(r == 0);

struct rowset *rowset[nrowsets];
Expand Down
2 changes: 1 addition & 1 deletion ft/tests/ftloader-test-extractor.cc
Original file line number Diff line number Diff line change
Expand Up @@ -402,7 +402,7 @@ static void test_extractor(int nrows, int nrowsets, const char *testdir) {
sprintf(temp, "%s/%s", testdir, "tempXXXXXX");

FTLOADER loader;
r = toku_ft_loader_open(&loader, NULL, generate, NULL, N, brts, dbs, fnames, compares, temp, ZERO_LSN, TXNID_NONE, true, 0, false);
r = toku_ft_loader_open(&loader, NULL, generate, NULL, N, brts, dbs, fnames, compares, temp, ZERO_LSN, nullptr, true, 0, false);
assert(r == 0);

struct rowset *rowset[nrowsets];
Expand Down
2 changes: 1 addition & 1 deletion ft/tests/ftloader-test-merge-files-dbufio.cc
Original file line number Diff line number Diff line change
Expand Up @@ -412,7 +412,7 @@ static void test (const char *directory, bool is_error) {
bt_compare_functions,
"tempxxxxxx",
*lsnp,
TXNID_NONE, true, 0, false);
nullptr, true, 0, false);
assert(r==0);
}

Expand Down
2 changes: 1 addition & 1 deletion ft/tests/ftloader-test-open.cc
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ static void test_loader_open(int ndbs) {
for (i = 0; ; i++) {
set_my_malloc_trigger(i+1);

r = toku_ft_loader_open(&loader, NULL, NULL, NULL, ndbs, brts, dbs, fnames, compares, "", ZERO_LSN, TXNID_NONE, true, 0, false);
r = toku_ft_loader_open(&loader, NULL, NULL, NULL, ndbs, brts, dbs, fnames, compares, "", ZERO_LSN, nullptr, true, 0, false);
if (r == 0)
break;
}
Expand Down

0 comments on commit 650f0e1

Please sign in to comment.