FT-689 : Add option to allow disabling of partial eviction of nodes #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
george-lorch
force-pushed
the
FT-689
branch
2 times, most recently
from
331dfd7
to
8e9b37d
Compare
| m_enable_partial_eviction = enabled; | ||
| } | ||
|
|
||
| bool evictor::get_enable_partial_eviction(void) { |
There was a problem hiding this comment.
I would consider making this method const.
There was a problem hiding this comment.
Yes, I already have done this per our Slack conversation. I haven't pushed it yet as I'm still working on introducing a test case that validates disabling of partial evictions. It would also be a good idea to test compress_buffers_before_eviction since there is no test for it that I could find and it is not documented anywhere.
|
Looks good to me. |
Requested by Vadim T. - "For start I propose we create an option --tokudb-enable-partial-eviction (ON by default)." Modified ft/tests/cachetable-5097 to take parameters and validate proper eviction behavior with and without partial eviction enabled.
|
Alrighty, made const and modified a test case to validate the new functionality. ctest passes locally. |
christianrober
added a commit
that referenced
this pull request
Aug 27, 2015
FT-689 : Add option to allow disabling of partial eviction of nodes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requested by Vadim T. - "For start I propose we create an option --tokudb-enable-partial-eviction (ON by default)."
Jenkins having issues now so no jenkins matrix test. local ctest passed as expected.