Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add possibility to initiate replset via ip address #225

Merged
merged 5 commits into from
Dec 21, 2018

Conversation

heartwilltell
Copy link
Contributor

No description provided.

Copy link
Contributor

@timvaillancourt timvaillancourt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test needs a small update for the change in signature:

ok  	github.com/percona/mongodb-orchestration-tools/pkg/pod	1.014s	coverage: 92.9% of statements
# github.com/percona/mongodb-orchestration-tools/pkg/pod/k8s
pkg/pod/k8s/pods_test.go:84:10: not enough arguments in call to p.Update
	have ([]"github.com/percona/mongodb-orchestration-tools/vendor/k8s.io/api/core/v1".Pod, []"github.com/percona/mongodb-orchestration-tools/vendor/k8s.io/api/apps/v1".StatefulSet)
	want ([]"github.com/percona/mongodb-orchestration-tools/vendor/k8s.io/api/core/v1".Pod, []"github.com/percona/mongodb-orchestration-tools/vendor/k8s.io/api/apps/v1".StatefulSet, []"github.com/percona/mongodb-orchestration-tools/vendor/k8s.io/api/core/v1".Service)
pkg/pod/k8s/pods_test.go:96:10: not enough arguments in call to p.Update
	have ([]"github.com/percona/mongodb-orchestration-tools/vendor/k8s.io/api/core/v1".Pod, nil)
	want ([]"github.com/percona/mongodb-orchestration-tools/vendor/k8s.io/api/core/v1".Pod, []"github.com/percona/mongodb-orchestration-tools/vendor/k8s.io/api/apps/v1".StatefulSet, []"github.com/percona/mongodb-orchestration-tools/vendor/k8s.io/api/core/v1".Service)

@codecov
Copy link

codecov bot commented Dec 20, 2018

Codecov Report

Merging #225 into master will decrease coverage by 0.98%.
The diff coverage is 23.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #225      +/-   ##
==========================================
- Coverage   63.98%   62.99%   -0.99%     
==========================================
  Files          38       38              
  Lines        1877     1916      +39     
==========================================
+ Hits         1201     1207       +6     
- Misses        585      616      +31     
- Partials       91       93       +2
Impacted Files Coverage Δ
pkg/pod/k8s/task.go 57.44% <6.45%> (-25.37%) ⬇️
pkg/pod/k8s/pods.go 86.36% <66.66%> (-4.87%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0272e00...cad63ea. Read the comment docs.

Copy link
Contributor

@timvaillancourt timvaillancourt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this always return nil?

func (p *Pods) getServiceFromPod(...

@heartwilltell heartwilltell merged commit 230f4b8 into master Dec 21, 2018
@heartwilltell heartwilltell deleted the feature/k8s-init-externally branch December 21, 2018 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants