-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add possibility to initiate replset via ip address #225
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test needs a small update for the change in signature:
ok github.com/percona/mongodb-orchestration-tools/pkg/pod 1.014s coverage: 92.9% of statements
# github.com/percona/mongodb-orchestration-tools/pkg/pod/k8s
pkg/pod/k8s/pods_test.go:84:10: not enough arguments in call to p.Update
have ([]"github.com/percona/mongodb-orchestration-tools/vendor/k8s.io/api/core/v1".Pod, []"github.com/percona/mongodb-orchestration-tools/vendor/k8s.io/api/apps/v1".StatefulSet)
want ([]"github.com/percona/mongodb-orchestration-tools/vendor/k8s.io/api/core/v1".Pod, []"github.com/percona/mongodb-orchestration-tools/vendor/k8s.io/api/apps/v1".StatefulSet, []"github.com/percona/mongodb-orchestration-tools/vendor/k8s.io/api/core/v1".Service)
pkg/pod/k8s/pods_test.go:96:10: not enough arguments in call to p.Update
have ([]"github.com/percona/mongodb-orchestration-tools/vendor/k8s.io/api/core/v1".Pod, nil)
want ([]"github.com/percona/mongodb-orchestration-tools/vendor/k8s.io/api/core/v1".Pod, []"github.com/percona/mongodb-orchestration-tools/vendor/k8s.io/api/apps/v1".StatefulSet, []"github.com/percona/mongodb-orchestration-tools/vendor/k8s.io/api/core/v1".Service)
Codecov Report
@@ Coverage Diff @@
## master #225 +/- ##
==========================================
- Coverage 63.98% 62.99% -0.99%
==========================================
Files 38 38
Lines 1877 1916 +39
==========================================
+ Hits 1201 1207 +6
- Misses 585 616 +31
- Partials 91 93 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this always return nil?
func (p *Pods) getServiceFromPod(...
No description provided.