CLOUD-46: Fix 'exit 1' on replset-init of restarted CR w/existing PVC data

[timvaillancourt]

This fixes a problem where the operator fails to initiate a replset that was already initiated before CR creation time. We should skip and exit 0, but instead we exit 1 with a "not master" error.

The fix ensures the replset config is loaded from the session before .IsInitiated() is called to check if the replset was already initiated here:

mongodb-orchestration-tools/controller/replset/initiator.go

Lines 60 to 62 in 9068d0e

	if rsCnfMan.IsInitiated() {
	return ErrReplsetInitiated
	}

Without this PR this ^^^ block is getting skipped.

[codecov]

Codecov Report

Merging #226 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #226      +/-   ##
==========================================
- Coverage   62.99%   62.98%   -0.01%     
==========================================
  Files          38       38              
  Lines        1916     1921       +5     
==========================================
+ Hits         1207     1210       +3     
- Misses        616      618       +2     
  Partials       93       93

Impacted Files	Coverage Δ
controller/replset/initiator.go	11.25% <0%> (+1.57%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 230f4b8...c135b85. Read the comment docs.