Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PMDCOS-5: Fix issue with pointers in manager_test.go test #241

Merged
merged 1 commit into from
Feb 7, 2019
Merged

PMDCOS-5: Fix issue with pointers in manager_test.go test #241

merged 1 commit into from
Feb 7, 2019

Conversation

timvaillancourt
Copy link
Contributor

  1. Create new &replset.Mongod{} struct for each mock-member in test. This resolves all hosts being the last-changed host:port.

@timvaillancourt timvaillancourt changed the title Fix issue with pointers in manager_test.go PMDCOS-5: Fix issue with pointers in manager_test.go Jan 31, 2019
@timvaillancourt timvaillancourt changed the title PMDCOS-5: Fix issue with pointers in manager_test.go PMDCOS-5: Fix issue with pointers in manager_test.go test Jan 31, 2019
@codecov
Copy link

codecov bot commented Feb 1, 2019 •
edited
Loading

Codecov Report

Merging #241 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #241   +/-   ##
=======================================
  Coverage   65.47%   65.47%           
=======================================
  Files          38       38           
  Lines        1932     1932           
=======================================
  Hits         1265     1265           
  Misses        568      568           
  Partials       99       99

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 286a3b1...6b452ed. Read the comment docs.

@timvaillancourt timvaillancourt merged commit cca05f5 into master Feb 7, 2019
@timvaillancourt timvaillancourt deleted the PMDCOS-5-fix-watcherManager-watch-test branch February 7, 2019 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heartwilltell heartwilltell heartwilltell approved these changes

@dAdAbird dAdAbird Awaiting requested review from dAdAbird

@delgod delgod Awaiting requested review from delgod

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@timvaillancourt @heartwilltell