PBM-1058: fix phys backups on datadirs with tailing / #802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Phys backup while trimming datadir from the file path always added
a slash to the trim prefix. In case datadir was set with a tailing
slash it led to a double slash and datadir wasn't trimmed at all
(`Trimprefix("/data/db/file1", "/data/db//")`). Therefore in the
backup's meta such files contain datadir and the restore would put them
in a subdirectory inside datadir, "/data/db/data/db/file1" instead of
"/data/db/file1".
This change fixes it.
olexandr-havryliak
approved these changes
Mar 14, 2023
defbin
approved these changes
Mar 14, 2023
|
sandraromanchenko
approved these changes
Mar 15, 2023
dAdAbird
added a commit
that referenced
this pull request
Mar 16, 2023
Phys backup while trimming datadir from the file path always added
a slash to the trim prefix. In case datadir was set with a tailing
slash it led to a double slash and datadir wasn't trimmed at all
(`Trimprefix("/data/db/file1", "/data/db//")`). Therefore in the
backup's meta such files contain datadir and the restore would put them
in a subdirectory inside datadir, "/data/db/data/db/file1" instead of
"/data/db/file1".
This change fixes it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Phys backup while trimming datadir from the file path always added a slash to the trim prefix. In case datadir was set with a tailing slash it led to a double slash and datadir wasn't trimmed at all (
Trimprefix("/data/db/file1", "/data/db//")). Therefore in the backup's meta such files contain datadir and the restore would put them in a subdirectory inside datadir, "/data/db/data/db/file1" instead of "/data/db/file1".This change fixes it.