Skip to content

Commit

Permalink
Suppress valgrind issue with rocksdb CacheEntryStats
Browse files Browse the repository at this point in the history
Summary: RocksDB is using STATIC_AVOID_DESTRUCTION with global objects that skips destructor so these global objects are not properly destructed. The code work around ASAN by forcing the destruction but not for valgrind. Going forward STATIC_AVOID_DESTRUCTION should be made valgrind-aware. Suppress these errors for now since they are one-time global only.

Reviewed By: luqun

Differential Revision: D29257815

fbshipit-source-id: 100c77ed582
  • Loading branch information
yizhang82 authored and facebook-github-bot committed Jun 23, 2021
1 parent 47b45a2 commit 8ee0867
Showing 1 changed file with 18 additions and 0 deletions.
18 changes: 18 additions & 0 deletions mysql-test/valgrind.supp
Original file line number Diff line number Diff line change
Expand Up @@ -2847,3 +2847,21 @@
fun:_Z41__static_initialization_and_destruction_0ii
...
}

{
Still reachable for once-per-process initializations
Memcheck:Leak
match-leak-kinds: reachable
...
fun:_ZN10my_rocksdb24RegisterCacheDeleterRoleEPFvRKNS_5SliceEPvENS_14CacheEntryRoleE
...
}

{
Still reachable for once-per-process initializations
Memcheck:Leak
match-leak-kinds: reachable
...
fun:_ZN10my_rocksdb24CacheEntryStatsCollectorINS_13InternalStats19CacheEntryRoleStatsEE9GetSharedEPNS_5CacheEPNS_11SystemClockEPSt10shared_ptrIS3_E
...
}

0 comments on commit 8ee0867

Please sign in to comment.