Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5.7 ps bug995624 #1295

Merged
merged 2 commits into from Jan 27, 2017
Merged

Conversation

robgolebiowski
Copy link
Contributor

I am updating rows_updated on slave after each batch of rows is replicated to slave. The other option would be to update rows_updated after each row is replicate to slave.

Copy link
Contributor

@laurynas-biveinis laurynas-biveinis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comments as for 5.6 + if you add slave filtering test, make it use 5.7 SQL to set it up instead of 5.6 command-line options

@robgolebiowski robgolebiowski force-pushed the 5.7-ps-bug995624 branch 2 times, most recently from 6f04974 to c6e37c5 Compare January 25, 2017 17:28
After each batch of rows get replicated on a slave server the
rows_update gets incremented by the number of rows successfuly updated,
i.e. inserted/updated/deleted on the slave server.
Changed slave table filtering to SQL (CHANGE REPLICATION FILTER)
from server option --replicate-do-table
Copy link
Collaborator

@percona-ysorokin percona-ysorokin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robgolebiowski robgolebiowski merged commit a727250 into percona:5.7 Jan 27, 2017
@robgolebiowski robgolebiowski deleted the 5.7-ps-bug995624 branch January 27, 2017 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants