Fix lp:1663452 "Resource allocation failures in 'CREATE/DROP COMPRESSION_DICTIONARY' result in server crashes (debug mode) | handle_fatal_signal (sig=6) in innobase_create_zip_dict" (5.6) #1412
Conversation
|
Jenkins build link |
percona-ysorokin
changed the title
sql/sql_zip_dict.cc
Outdated
| default: | ||
| DBUG_ASSERT(0); |
There was a problem hiding this comment.
Perhaps debug build should continue to assert so that further nonspecific errors are caught and handled?
| @@ -94,8 +98,19 @@ int mysql_create_zip_dict(THD* thd, const char* name, ulong name_len, | |||
| error= ER_READ_ONLY_MODE; | |||
| my_error(error, MYF(0)); | |||
| break; | |||
| case HA_CREATE_ZIP_DICT_OUT_OF_MEMORY: | |||
There was a problem hiding this comment.
The testcase handles HA_CREATE_ZIP_DICT_TOO_MANY_CONCURRENT_TRXS, how did you come up with the other two - by code review? Is it worth to add debug injection tests for them too?
There was a problem hiding this comment.
Yes, just by reviewing the most typical resource allocation problems.
Test case extended with checks for ER_RECORD_FILE_FULL as well as for ER_OUT_OF_RESOURCES.
|
Please edit the bug title to something docs/users could use, but leaving the assert there too, e.g. "Failure to blah results in blah | handle_fatal_signal ... " |
percona-ysorokin
changed the title
percona-ysorokin
changed the title
percona-ysorokin
force-pushed
the
ps-5.6-bug1663452-cc_ib_create_table_fail_too_many_trx
branch
from
47cb2b2
to
d949a43
Compare
…SSION_DICTIONARY' result in server crashes (debug mode) | handle_fatal_signal (sig=6) in innobase_create_zip_dict"
'innobase_create_zip_dict()' / 'mysql_create_zip_dict()' and
'innobase_drop_zip_dict()' / 'mysql_drop_zip_dict()' extended with additional
error return codes ('Out of memory', 'Out of disk space' and
'Too many concurrent transactions') so that proper diagnostic messages are
printed when 'CREATE/DROP COMPRESSION_DICTIONARY' statements encounter
resource shortage problem.
'innodb.xtradb_compressed_columns_debug' extended with corresponding checks
for those three types of resource allocation problems.
percona-ysorokin
force-pushed
the
ps-5.6-bug1663452-cc_ib_create_table_fail_too_many_trx
branch
from
d949a43
to
0fce4ca
Compare
|
Updated Jenkins build link |
|
No need to propagate Launchpad bug title changes to Github PRs |
| SET debug = '+d,simulate_out_of_memory'; | ||
| --error ER_OUT_OF_RESOURCES | ||
| DROP COMPRESSION_DICTIONARY d1; | ||
| SET debug = '+d,simulate_out_of_memory'; |
There was a problem hiding this comment.
No, this line was added deliberately. 'simulate_out_of_memory' automatically switches itself off upon reaching this DBUG sync point (to make 'out of memory' error a one time occasion).
'innobase_create_zip_dict()' / 'mysql_create_zip_dict()' and
'innobase_drop_zip_dict()' / 'mysql_drop_zip_dict()' extended with additional
error return codes ('Out of memory', 'Out of disk space' and
'Too many concurrent transactions') so that proper diagnostic messages are
printed when 'CREATE/DROP COMPRESSION_DICTIONARY' statements encounter
resource shortage problem.
'innodb.xtradb_compressed_columns_debug' extended with corresponding checks
for those three types of resource allocation problems.