Fix lp:1659992 "Function over userstat tables cause mysql to crash" (5.6) #1541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins build link |
laurynas-biveinis
suggested changes
Mar 23, 2017
Some 'SELECT' statements over 'table_statistics' IS table used to call 'check_grant()' from 'fill_schema_table_stats()' with 'table_list' parameter which did not include any element that would have 'next_global' pointing to 'thd->lex->query_tables_own_last'. This was a violation of 'check_grant()' pre-conditions. Fixed by backporting part of the 5.7 "wl#6960: Refactoring auth code: milestone 1, new physical file structure" (commit 0ed74a1) which added additional 'NULL' check to 'TABLE_LIST' iteration in 'check_grant()'. Extended 'main.percona_userstat' MTR test case.
…ug1659992-function_over_userstat
percona-ysorokin
force-pushed
the
ps-5.6-bug1659992-function_over_userstat
branch
from
daca0de
to
55ce64c
Compare
|
Updated Jenkins build link (as no code changes since the previous commit, just single test run) |
laurynas-biveinis
approved these changes
Mar 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.