MYR-151 : json data type overwrites data in table on insert #1912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The json test feels quite hackish but I could not find any other decent example, so I included some of the appropriate tests from mysql-test/suite/json/inc and appended the test cases that Tomislav was using. Incidentally, there is absolutely no TokuDB test for JSON in 5.7 at all. http://jenkins.percona.com/view/5.7/job/mysql-5.7-param/1182/ |
laurynas-biveinis
approved these changes
Aug 31, 2017
| @@ -0,0 +1,21 @@ | |||
| --source include/have_rocksdb.inc | |||
|
|
|||
| # needed by theses json .inc tests | |||
|
Actually that is a good point re: beta JSON. I did ask Tomislav to test JSON pretty thoroughly but this really is probably worth creating an RQA task to 'clear' it before we call it a GA feature. |
MYR-152 : the json binary value contains invalid data - MyRocks was entirely missing JSON support, which seems to be to just treat, parck, and unpack MYSQL_TYPE_JSON exacely like MYSQL_TYPE_BLOB. - Added changes to support JSON types. - Added new test that includes some tests from mysql-test/suite/json/include and also does some basic JSON store/retrieve.
george-lorch
force-pushed
the
ps-5.7-MYR-151-152
branch
from
2251a23
to
01382ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MYR-152 : the json binary value contains invalid data
parck, and unpack MYSQL_TYPE_JSON exacely like MYSQL_TYPE_BLOB.
and also does some basic JSON store/retrieve.