Fix bug 1552673 (Buffer pool may fail to remove dirty pages for a par… #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ticular tablespace from the flush list) buf_flush_or_remove_pages logic is incorrect if one of the "must_restart" arg-taking subroutines (buf_flush_or_remove_page and buf_flush_try_yield) set it to true, i.e. it is ignored and one more loop iteration is performed before exit. Fix by checking must_restart and quitting the loop in the same iteration for both of these subroutines.
laurynas-biveinis
added a commit
that referenced
this pull request
Mar 7, 2016
Fix bug 1552673 (Buffer pool may fail to remove dirty pages for a par…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ticular tablespace from the flush list)
buf_flush_or_remove_pages logic is incorrect if one of the
"must_restart" arg-taking subroutines (buf_flush_or_remove_page and
buf_flush_try_yield) set it to true, i.e. it is ignored and one more
loop iteration is performed before exit.
Fix by checking must_restart and quitting the loop in the same
iteration for both of these subroutines.
http://jenkins.percona.com/job/percona-server-5.6-param/1085/