Bug fix for lp:1536663. #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Vlad, is this a GCA branch and merge to 5.7? It looks like no GCA and two individual commits, one to 5.6 and one to 5.7. |
When read-free-replication is enabled for tokudb and there is no explicit pk for replicated table there can be dublicated records in the table on update operation. Consider this update operation: UPDATE t SET a = a + 10 WHERE b = 'b'; The master does rows lookup and updates the rows which values correspond to the condition. The update events are written to binary log with rows values from the master. As rows lookup is forbidden for slave the new rows are added instead of updating corresponding rows. Without the fix there will be several rows with b = 'b' in the table on slave instead of one updated row. The fix disables RFR for tables without explicit pk and do rows lookup for update and delete binlog events and issues warning.
Yes, you a right. Rebased. http://jenkins.percona.com/view/5.7/job/mysql-5.7-param/150/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When read-free-replication is enabled for tokudb and there is no
explicit pk for replicated table there can be dublicated records in the table
on update operation.
Consider this update operation:
UPDATE t SET a = a + 10 WHERE b = 'b';
The master does rows lookup and updates the rows which values
correspond to the condition. The update events are written to binary log with
rows values from the master. As rows lookup is forbidden for slave
the new rows are added instead of updating corresponding rows.
Without the fix there will be several rows with b = 'b' in the table
on slave instead of one updated row.
The fix disables RFR for tables without explicit pk and do rows lookup
for update and delete binlog events and issues warning.
http://jenkins.percona.com/view/PS%205.6/job/percona-server-5.6-param/1122/