Starts lldb in MacOS terminal for the server instances ran from mtr. #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlad-lesin
force-pushed
the
lldb-in-terminal-5.6
branch
from
6320fe6
to
b2dd844
Compare
|
Have you tried -n flag for open to start a new Terminal process? Would that resolve the drawback? |
vlad-lesin
force-pushed
the
lldb-in-terminal-5.6
branch
from
b2dd844
to
7b868ac
Compare
The patch uses system "open" command to start lldb in terminal: open -n -W -a Terminal path_to_script where 'path_to_script' is the path to the script which starts lldb with corresponding options.
vlad-lesin
force-pushed
the
lldb-in-terminal-5.6
branch
from
7b868ac
to
c98aa17
Compare
Yes, this helped, thank you. Fixed. |
|
LGTM, please upmerge to 5.7 and also send to Oracle by OCA |
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Apr 23, 2020
percona#470) Summary: ?m plain C to struct++ Touched up all calls to old implementation. Closes facebook/mysql-5.6#470 Differential Revision: D4316193 Pulled By: gunnarku fbshipit-source-id: ed527f8 fbshipit-source-id: 270f9132381
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Feb 24, 2021
percona#470) Summary: ?m plain C to struct++ Touched up all calls to old implementation. Closes facebook/mysql-5.6#470 Differential Revision: D4316193 Pulled By: gunnarku fbshipit-source-id: ed527f8 fbshipit-source-id: 270f9132381
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Nov 15, 2021
percona#470) (percona#470) Summary: ?m plain C to struct++ Touched up all calls to old implementation. Closes facebook/mysql-5.6#470 Differential Revision: D4316193 (facebook/mysql-5.6@ca2174a) Pulled By: gunnarku fbshipit-source-id: 459f50d704d
ldonoso
pushed a commit
to ldonoso/percona-server
that referenced
this pull request
Mar 15, 2022
percona#470) (percona#470) Summary: ?m plain C to struct++ Touched up all calls to old implementation. Closes facebook/mysql-5.6#470 Differential Revision: D4316193 Pulled By: gunnarku
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Apr 9, 2024
percona#470) (percona#470) Summary: ?m plain C to struct++ Touched up all calls to old implementation. Closes facebook/mysql-5.6#470 Differential Revision: D4316193 Pulled By: gunnarku
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The patch uses system "open" command to start lldb in terminal:
open -W -a Terminal path_to_script
where 'path_to_script' is the path to the script which starts lldb with
corresponding options.
The drawback of this approach is that mtr waits for the terminal
termination instead of waiting for the correspondent terminal windows to
be closed. So if you use system terminal for work and there are already
opened windows/tabs mtr will wait until all of them are closed. The
workaround is in using third-party terminals(for example iterm) for work
and the standard system terminal for debugging.
http://jenkins.percona.com/view/PS%205.6/job/percona-server-5.6-param/1123/