DB-962 : broken memory management in TokuDB 5.6.28-76.1 #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue is in flags that analysis uses when setting up DBT structs to extract keys from PerconaFT. Code previously used DB_DBT_REALLOC for some unknown reason rather than '0'. DB_DBT_REALLOC places the burden of managing the memory of the returned keys on the user of PerconaFT, '0' leaves that burden with PurconaFT and the key/value data is managed and freed by the cursor->close call. There is no apparant performance difference between the two or any benefit of using one over the other. - Removed DB_DBT_REALLOC from initial DBT key flags. - Verified that memory is properly managed on cursor->c_next and cursor->close calls.
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Apr 23, 2020
percona#480) Summary: This is the last pull request for the const fix of all the files under storage/rocksdb. The changes will improve the robustness of the code and make it easier for refactoring in the future. Closes facebook/mysql-5.6#480 Differential Revision: D4349370 Pulled By: sidigit1205 fbshipit-source-id: bbe7963 fbshipit-source-id: 6de83f61428
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Feb 24, 2021
percona#480) Summary: This is the last pull request for the const fix of all the files under storage/rocksdb. The changes will improve the robustness of the code and make it easier for refactoring in the future. Closes facebook/mysql-5.6#480 Differential Revision: D4349370 Pulled By: sidigit1205 fbshipit-source-id: bbe7963 fbshipit-source-id: 6de83f61428
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Nov 15, 2021
percona#480) (percona#480) Summary: This is the last pull request for the const fix of all the files under storage/rocksdb. The changes will improve the robustness of the code and make it easier for refactoring in the future. Closes facebook/mysql-5.6#480 Differential Revision: D4349370 (facebook/mysql-5.6@649a967) Pulled By: sidigit1205 fbshipit-source-id: ac7d4598875
ldonoso
pushed a commit
to ldonoso/percona-server
that referenced
this pull request
Mar 15, 2022
percona#480) (percona#480) Summary: This is the last pull request for the const fix of all the files under storage/rocksdb. The changes will improve the robustness of the code and make it easier for refactoring in the future. Closes facebook/mysql-5.6#480 Differential Revision: D4349370 Pulled By: sidigit1205
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Apr 9, 2024
percona#480) (percona#480) Summary: This is the last pull request for the const fix of all the files under storage/rocksdb. The changes will improve the robustness of the code and make it easier for refactoring in the future. Closes facebook/mysql-5.6#480 Differential Revision: D4349370 Pulled By: sidigit1205
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue is in flags that analysis uses when setting up DBT structs to extract keys from PerconaFT.
Code previously used DB_DBT_REALLOC for some unknown reason rather than '0'.
DB_DBT_REALLOC places the burden of managing the memory of the returned keys on the user of PerconaFT,
'0' leaves that burden with PurconaFT and the key/value data is managed and freed by the cursor->close call.
There is no apparant performance difference between the two or any benefit of using one over the other.