Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PS-8908: Mysqld crash when user forgets to set debug timeout #5117

Open
wants to merge 1 commit into
base: 8.0
Choose a base branch
from
Open

PS-8908: Mysqld crash when user forgets to set debug timeout #5117

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions sql/debug_sync.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1975,6 +1975,11 @@ bool debug_sync_set_action(THD *thd, const char *action_str, size_t len) {
assert(thd);
assert(action_str);

// A zero value keeps the facility disabled.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess MTR framework always has debug sync enabled? Is it possible to use different cnf or start mysqld without debug sync enabled and execute testcase provided in the bug report?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, probably MTR framework always sets debug_sync_timeout, so the problem is not visible. The problem is visible if you start the server standalone without specifying it and execute debug sync queries manually like it is in the bug report.

if (!opt_debug_sync_timeout) {
return false;
}

value = strmake_root(thd->mem_root, action_str, len);
rc = debug_sync_eval_action(thd, value);
return rc;
Expand Down