PS-9218: Merge MySQL 8.4.0 (fix gcc-14 build) #5309
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -440,7 +440,7 @@ int Ndb::computeHash(Uint32 *retval, const NdbDictionary::Table *table, | |||
| while (true) { | |||
| if (buf == nullptr) { | |||
| bufLen = sumlen; | |||
| buf = malloc(bufLen); | |||
| buf = calloc(bufLen, 1); | |||
There was a problem hiding this comment.
assigning newly created gsl::owner<> to non-owner void *
| @@ -440,7 +440,7 @@ | |||
| while (true) { | |||
| if (buf == nullptr) { | |||
| bufLen = sumlen; | |||
| buf = malloc(bufLen); | |||
| buf = calloc(bufLen, 1); | |||
There was a problem hiding this comment.
Call to calloc has an allocation size of 0 bytes
| @@ -440,7 +440,7 @@ | |||
| while (true) { | |||
| if (buf == nullptr) { | |||
| bufLen = sumlen; | |||
| buf = malloc(bufLen); | |||
| buf = calloc(bufLen, 1); | |||
There was a problem hiding this comment.
do not manage memory manually; consider a container or a smart pointer
|
Please try to compile in RelWithDebInfo mode - there are more warnings. |
oleksandr-kachan
force-pushed
the
PS-9218-gcc-14
branch
from
09a31a9
to
f471726
Compare
|
|
||
| if (!mct_log_file) { | ||
| printf("Warning: can not open log file (%s): %s. Logging is disabled.\n", | ||
| (const char *)mct_log_file_path, (const char *)strerror(errno)); | ||
| mct_log_file_path.str().c_str(), (const char *)strerror(errno)); |
There was a problem hiding this comment.
C-style casts are discouraged; use static_cast/const_cast/reinterpret_cast
| @@ -1332,7 +1332,7 @@ void NdbImportUtil::free_rows(RowList &src) { | |||
| NdbImportUtil::Blob::Blob() { | |||
| m_blobsize = 0; | |||
| m_allocsize = 0; | |||
| m_data = new uchar[0]; | |||
| m_data = new uchar[1]; | |||
There was a problem hiding this comment.
assigning newly created gsl::owner<> to non-owner uchar * (aka unsigned char *)
| @@ -1332,7 +1332,7 @@ | |||
| NdbImportUtil::Blob::Blob() { | |||
There was a problem hiding this comment.
m_data should be initialized in a member initializer of the constructor
| NdbImportUtil::Blob::Blob() { | |
| NdbImportUtil::Blob::Blob(), m_data(new uchar[1]) { |
| @@ -1332,7 +1332,7 @@ | |||
| NdbImportUtil::Blob::Blob() { | |||
| m_blobsize = 0; | |||
| m_allocsize = 0; | |||
| m_data = new uchar[0]; | |||
| m_data = new uchar[1]; | |||
There was a problem hiding this comment.
m_data should be initialized in a member initializer of the constructor
| m_data = new uchar[1]; | |
| snprintf(mct_log_file_path, FILE_PATH_SIZE, "%s/%s.out.log", | ||
| (const char *)tmp_dir, (const char *)test_case_name); | ||
| std::stringstream mct_log_file_path; | ||
| mct_log_file_path << tmp_dir << "/" << test_case_name << ".out.log"; |
There was a problem hiding this comment.
Since this is C++20, consider using std::format:
const std::string str = std::format("{}/{}.out.log", tmp_dir, test_case_name);
There was a problem hiding this comment.
I had this idea but I'm afraid not all expected compilers support it
oleksandr-kachan
force-pushed
the
PS-9218-gcc-14
branch
from
f471726
to
88d7f2a
Compare
oleksandr-kachan
force-pushed
the
PS-9218-gcc-14
branch
from
88d7f2a
to
5f03663
Compare
oleksandr-kachan
merged commit 7f4b4fd
into
percona:release-8.4.0-1
https://perconadev.atlassian.net/browse/PS-9218