PS-9222 Include reordered fields when calculating mlog buffer size #5321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VarunNagaraju
force-pushed
the
PS-9222-8.0
branch
from
150cc7d
to
d688099
Compare
zhry110
reviewed
Jun 21, 2024
VarunNagaraju
force-pushed
the
PS-9222-8.0
branch
from
d688099
to
5c0acef
Compare
VarunNagaraju
force-pushed
the
PS-9222-8.0
branch
from
5c0acef
to
2bbb14b
Compare
mysql-test/suite/innodb/t/instant_alter_stored_column_order.test
Outdated
Show resolved
Hide resolved
mysql-test/suite/innodb/t/instant_alter_stored_column_order.test
Outdated
Show resolved
Hide resolved
VarunNagaraju
force-pushed
the
PS-9222-8.0
branch
from
2bbb14b
to
c4e0cfe
Compare
satya-bodapati
requested changes
Jun 25, 2024
mysql-test/suite/innodb/t/instant_alter_stored_column_order.test
Outdated
Show resolved
Hide resolved
VarunNagaraju
force-pushed
the
PS-9222-8.0
branch
from
c4e0cfe
to
f8b1da5
Compare
VarunNagaraju
force-pushed
the
PS-9222-8.0
branch
2 times, most recently
from
7d42d75
to
63a614f
Compare
VarunNagaraju
force-pushed
the
PS-9222-8.0
branch
from
63a614f
to
10452c3
Compare
https://perconadev.atlassian.net/browse/PS-9222 Problem ======= When writing to the redo log, an issue of column order change not being recorded with INSTANT DDL was fixed by creating an array with size equal to the number of fields in the index which kept track of whether the original position of the field was changed or not. Later, that array would be used to make a decision on logging the field. But, this solution didn't take into account the fact that there could be column prefixes because of the primary key. This resulted in inaccurate entries being filled in the fields_with_changed_order[] array. Solution ======== It is fixed by using the method, get_col_phy_pos() which takes into account the existence of column prefix instead of get_phy_pos() while generating fields_with_changed_order[] array.
https://perconadev.atlassian.net/browse/PS-9222 Problem ======= When writing to the redo log, an issue of column order change not being recorded with INSTANT DDL was fixed by checking if the fields are also reordered, then adding the columns into the list. However when calculating the size of the buffer this fix doesn't take account the extra fields that may be logged, and causing the assertion on the buffer size failed eventually. Solution ======== To calculate the buffer size correctly, we move the logic of finding reordered fiedls before buffer size calculation, then count the number of fields with the same logic when deciding if a field needs to be logged.
VarunNagaraju
force-pushed
the
PS-9222-8.0
branch
from
10452c3
to
39e9957
Compare
VarunNagaraju
merged commit 86bde10
into
percona:release-8.0.37-29
8 of 28 checks passed
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| static void log_index_get_size_needed( | ||
| const dict_index_t *index, size_t size, uint16_t n, bool is_comp, | ||
| bool is_versioned, bool is_instant, | ||
| const std::unique_ptr<bool[]> &changed_order, size_t &size_needed) { |
There was a problem hiding this comment.
parameter changed_order is unused
Suggested change
| const std::unique_ptr<bool[]> &changed_order, size_t &size_needed) { | |
| size_t &size_needed) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://perconadev.atlassian.net/browse/PS-9222
Problem
Upstream commit e6e13a8 tries to fix an issue that doesn't log the fields that changes orders when using ALGORITHM=instant, by checking if the fields is also reordered, then adding the columns into the list. However when calculating the size of the buffer this fix doesn't take account the extra fields that may be logged, and causing the assertion on the buffer size failed eventually.
Solution
To calculate the buffer size correctly, we move the logic of finding reordered fiedls before buffer size calculation, then count the number of fields with the same logic when deciding if a field needs to be logged.