Fix bug 1581949 (Querying GLOBAL_TEMPORARY_TABLES crashes if temp-tab… #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,60 @@ | |||
| --source include/count_sessions.inc | |||
|
|
|||
There was a problem hiding this comment.
--source include/have_innodb.inc
|
LGTM |
…le owning threads execute new queries) INFORMATION_SCHEMA.GLOBAL_TEMPORARY_TABLES query cloning temp table handler passed the memory root of the temp table connection thread object. This memory root is being freed at the end of query of that thread, which may result, depending on scheduling, in the GLOBAL_TEMPORARY_TABLES-querying thread accessing cloned object after it has been freed. Fixed by using a memory root of the GLOBAL_TEMPORARY_TABLES-querying thread. Add percona_show_temp_tables_debug testcase to test this exact scenario and percona_show_temp_tables_stress to test querying GLOBAL_TEMPORARY_TABLES in parallel to creating and destroying them.
laurynas-biveinis
force-pushed
the
bug1581949-5.5
branch
from
cac666e
to
d2645b8
Compare
|
All comments addressed, http://jenkins.percona.com/job/percona-server-5.5-param/1226/ for the changed testcase only |
|
Looks good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…le owning threads execute new queries)
INFORMATION_SCHEMA.GLOBAL_TEMPORARY_TABLES query cloning temp table
handler passed the memory root of the temp table connection thread
object. This memory root is being freed at the end of query of that
thread, which may result, depending on scheduling, in the
GLOBAL_TEMPORARY_TABLES-querying thread accessing cloned object after it
has been freed.
Fixed by using a memory root of the GLOBAL_TEMPORARY_TABLES-querying
thread.
Add percona_show_temp_tables_debug testcase to test this exact scenario
and percona_show_temp_tables_stress to test querying
GLOBAL_TEMPORARY_TABLES in parallel to creating and destroying them.
http://jenkins.percona.com/job/percona-server-5.5-param/1225/