Bug1581949 5.6 #544
Merged
Bug1581949 5.6 #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
…le owning threads execute new queries) INFORMATION_SCHEMA.GLOBAL_TEMPORARY_TABLES query cloning temp table handler passed the memory root of the temp table connection thread object. This memory root is being freed at the end of query of that thread, which may result, depending on scheduling, in the GLOBAL_TEMPORARY_TABLES-querying thread accessing cloned object after it has been freed. Fixed by using a memory root of the GLOBAL_TEMPORARY_TABLES-querying thread. Add percona_show_temp_tables_debug testcase to test this exact scenario and percona_show_temp_tables_stress to test querying GLOBAL_TEMPORARY_TABLES in parallel to creating and destroying them.
laurynas-biveinis
force-pushed
the
bug1581949-5.6
branch
from
e5cb104
to
cb58e9c
Compare
|
Looks good |
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Apr 23, 2020
Summary:
Updated code to use DBUG_ENTER_FUNC instead of DBUG_ENTER("Function name") in storage/rocksdb
Closes facebook/mysql-5.6#544
Test Plan:
Imported from GitHub, without a `Test Plan:` line.
Successfully ran ~/mysql/tools/mysqltest.sh --testset=RocksDBBig
Reviewed By: gunnarku
Differential Revision: D4609243
Pulled By: aartibasant
fbshipit-source-id: 2ab6166bfbf
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Feb 24, 2021
Summary:
Updated code to use DBUG_ENTER_FUNC instead of DBUG_ENTER("Function name") in storage/rocksdb
Closes facebook/mysql-5.6#544
Test Plan:
Imported from GitHub, without a `Test Plan:` line.
Successfully ran ~/mysql/tools/mysqltest.sh --testset=RocksDBBig
Reviewed By: gunnarku
Differential Revision: D4609243
Pulled By: aartibasant
fbshipit-source-id: 2ab6166bfbf
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Nov 15, 2021
Summary:
Updated code to use DBUG_ENTER_FUNC instead of DBUG_ENTER("Function name") in storage/rocksdb
Closes facebook/mysql-5.6#544
Reviewed By: gunnarku
Differential Revision: D4609243 (facebook/mysql-5.6@4207a0c)
Pulled By: aartibasant
fbshipit-source-id: 6f106141675
ldonoso
pushed a commit
to ldonoso/percona-server
that referenced
this pull request
Mar 15, 2022
Summary:
Updated code to use DBUG_ENTER_FUNC instead of DBUG_ENTER("Function name") in storage/rocksdb
Closes facebook/mysql-5.6#544
Reviewed By: gunnarku
Differential Revision: D4609243
Pulled By: aartibasant
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Apr 9, 2024
Summary:
Updated code to use DBUG_ENTER_FUNC instead of DBUG_ENTER("Function name") in storage/rocksdb
Closes facebook/mysql-5.6#544
Reviewed By: gunnarku
Differential Revision: D4609243
Pulled By: aartibasant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://jenkins.percona.com/job/percona-server-5.6-param/1149/