Fix bug 1587840 / 81675 (mysqlbinlog does not free the existing conne… #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ction before opening new remote one) If mysqlbinlog is invoked with --read-from-remote-server and several binlog file names, each file will be read with the server connection re-opened. But the existing connection is only closed on mysqlbinlog termination, not before a new connection is opened for the next file. This causes a memory leak. Fix by closing the old connection, if any, at the start of safe_connect().
|
LGTM |
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Apr 23, 2020
percona#566) Summary: … source directive also, don't fail if the table t already existed. Closes facebook/mysql-5.6#566 Differential Revision: D4705949 Pulled By: jkedgar fbshipit-source-id: a874b08d97d
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Feb 24, 2021
percona#566) Summary: … source directive also, don't fail if the table t already existed. Closes facebook/mysql-5.6#566 Differential Revision: D4705949 Pulled By: jkedgar fbshipit-source-id: a874b08d97d
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Nov 15, 2021
…?nd=20so=20must=20declare=20that=20with=20a=E2=80=A6=20(percona#566)?= (percona#566) Summary: … source directive also, don't fail if the table t already existed. Closes facebook/mysql-5.6#566 Differential Revision: D4705949 (facebook/mysql-5.6@fbbf596) Pulled By: jkedgar fbshipit-source-id: 6eefee35cee
ldonoso
pushed a commit
to ldonoso/percona-server
that referenced
this pull request
Mar 15, 2022
…?nd=20so=20must=20declare=20that=20with=20a=E2=80=A6=20(percona#566)?= (percona#566) Summary: … source directive also, don't fail if the table t already existed. Closes facebook/mysql-5.6#566 Differential Revision: D4705949 Pulled By: jkedgar
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Apr 9, 2024
…?nd=20so=20must=20declare=20that=20with=20a=E2=80=A6=20(percona#566)?= (percona#566) Summary: … source directive also, don't fail if the table t already existed. Closes facebook/mysql-5.6#566 Differential Revision: D4705949 Pulled By: jkedgar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ction before opening new remote one)
If mysqlbinlog is invoked with --read-from-remote-server and several
binlog file names, each file will be read with the server connection
re-opened. But the existing connection is only closed on mysqlbinlog
termination, not before a new connection is opened for the next
file. This causes a memory leak.
Fix by closing the old connection, if any, at the start of
safe_connect().
http://jenkins.percona.com/job/percona-server-5.5-param/1230/