Fix for bug 1557293 in 5.7 #573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
http://jenkins.percona.com/view/5.7/job/mysql-5.7-param/195/#showFailuresLink Jenkins is showing that something is very wrong with PS 5.7, but failures seems not related to the bug fix. |
gl-sergei
force-pushed
the
5.7-ps-bug1557293
branch
from
9b06e8c
to
d81df64
Compare
Instead of using fixed-length buffer for escaped query, escape all strings and do other formatting into single buffer of size 4096 bytes. When 4096 bytes is not enough, allocate larger buffer (one per thread).
Bug 1588439: Audit log hangs when trying to write log record of
length audit_log_buffer_size
Bug 1588447: Audit log in ASYNC mode should not skip log records
which don't fit into log buffer
Fix for bug 1588439:
Adjust conditions in audit_log_buffer_write and audit_log_flush to
allow records to pass through.
Fix for bug 1588447:
In ASYNCHRONOUS mode when audit record is longer than log buffer
size, log this record directly into file.
gl-sergei
force-pushed
the
5.7-ps-bug1557293
branch
from
d81df64
to
82e11f4
Compare
|
It is straight merge with some adjustments for PFS instrumentation of my_malloc/my_realloc. Self-approving. |
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Apr 23, 2020
Summary: This diff adds more test coverages for bloomfilter tests with reverse order column family Closes facebook/mysql-5.6#573 Test Plan: mtr Reviewed By: alxyang Differential Revision: D4725588 Pulled By: yoshinorim fbshipit-source-id: 0cc50b38923
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Feb 24, 2021
Summary: This diff adds more test coverages for bloomfilter tests with reverse order column family Closes facebook/mysql-5.6#573 Test Plan: mtr Reviewed By: alxyang Differential Revision: D4725588 Pulled By: yoshinorim fbshipit-source-id: 0cc50b38923
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Nov 15, 2021
Summary: This diff adds more test coverages for bloomfilter tests with reverse order column family Closes facebook/mysql-5.6#573 Differential Revision: D4725588 (facebook/mysql-5.6@163cd2a) Pulled By: yoshinorim fbshipit-source-id: 363a4e895d2
ldonoso
pushed a commit
to ldonoso/percona-server
that referenced
this pull request
Mar 15, 2022
Summary: This diff adds more test coverages for bloomfilter tests with reverse order column family Closes facebook/mysql-5.6#573 Differential Revision: D4725588 Pulled By: yoshinorim
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Apr 9, 2024
Summary: This diff adds more test coverages for bloomfilter tests with reverse order column family Closes facebook/mysql-5.6#573 Differential Revision: D4725588 Pulled By: yoshinorim
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.