Bug 1435099: Audit Log events do not report default DB #649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| connection default; | ||
|
|
||
| --exec $MYSQL --user=user1 --password=111 test -e "use db1; SELECT * FROM t;" | ||
| # is there better way to check that server reset connection initiated by mysql cli? |
There was a problem hiding this comment.
Wrapping exec with include/count_connections and include/wait_until_connection_count should do this
|
No testcase for the install plugin with an open parallel connection? |
gl-sergei
force-pushed
the
5.6-ps-audit-log-default-db
branch
4 times, most recently
from
a92aa36
to
807084d
Compare
jenkins build: http://jenkins.percona.com/view/PS%205.6/job/percona-server-5.6-param/1231/ |
| GRANT ALL PRIVILEGES ON ąžąžąžą.* TO 'user2'@'%'; | ||
|
|
||
| # truncate audit log | ||
| UNINSTALL PLUGIN audit_log; |
There was a problem hiding this comment.
This gives "plugin is busy and will be uninstalled on shutdown"
|
Something else about encodings, in e.g. XML the header is . If the server encoding is different, are the strings transcoded before logging? |
See my comment above:
|
|
Ah, OK, it's the same thing we are talking about :) Have you logged the bug? |
Blueprint https://blueprints.launchpad.net/percona-server/+spec/audit-log-default-db Add field `DB' for `MYSQL_AUDIT_GENERAL_STATUS' records.
gl-sergei
force-pushed
the
5.6-ps-audit-log-default-db
branch
from
807084d
to
9f9e2c2
Compare
|
|
LGTM |
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Apr 23, 2020
Summary: Changes: * reset m_detailed_error to empty string * added tests to verify snapshot conflicts message disappears on consecutive deadlocks Closes facebook/mysql-5.6#649 Differential Revision: D5383202 fbshipit-source-id: aff56938297
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Feb 24, 2021
Summary: Changes: * reset m_detailed_error to empty string * added tests to verify snapshot conflicts message disappears on consecutive deadlocks Closes facebook/mysql-5.6#649 Differential Revision: D5383202 fbshipit-source-id: aff56938297
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Nov 15, 2021
…#649) Summary: Changes: * reset m_detailed_error to empty string * added tests to verify snapshot conflicts message disappears on consecutive deadlocks Closes facebook/mysql-5.6#649 Differential Revision: D5383202 (facebook/mysql-5.6@1328f8f) fbshipit-source-id: a4868703e93
ldonoso
pushed a commit
to ldonoso/percona-server
that referenced
this pull request
Mar 15, 2022
…#649) Summary: Changes: * reset m_detailed_error to empty string * added tests to verify snapshot conflicts message disappears on consecutive deadlocks Closes facebook/mysql-5.6#649 Differential Revision: D5383202
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Apr 9, 2024
…#649) Summary: Changes: * reset m_detailed_error to empty string * added tests to verify snapshot conflicts message disappears on consecutive deadlocks Closes facebook/mysql-5.6#649 Differential Revision: D5383202
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blueprint
https://blueprints.launchpad.net/percona-server/+spec/audit-log-default-db
Add field
DBforMYSQL_AUDIT_GENERAL_STATUSrecords.