DB-1004 : storage/tokudb/ha_tokudb.cc:315 release: Assertion `Handler… #695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ton: _use_count != 0 ' failed (errno=0) - Added extra assertion in job_manager_t::cancel to ensure no cancelling of already cancelled job. - Added check in job_manager_t::destroy to ensure cancelled jobs are not cancelled again.
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Apr 23, 2020
Summary: update-submodule: rocksdb The stall counters are already shown in 'SHOW ENGINE ROCKSDB STATUS output' but this command is a bit expensive to run and you have to parse the output to monitor these values. This branch adds these counters to structured output of SHOW GLOBAL STATUS command. Also fixed the bug in INFORMATION_SCHEMA.ROCKSDB_COMPACTION_STATS which showed only integer values but not float. The rocksdb module was updated to bring [this](facebook/rocksdb#2794 (review)) change which has the following changes to GetMapProperty method: 1. Changed values from double to string 2. Change existing keys to start with "compaction." prefix for all keys returned by old version of GetMapProperty. 3. Added stall values with keys starting with "io_stall." prefix Closes facebook/mysql-5.6#695 Test Plan: * Check that compaction level metrics are still published to INFORMATION_SCHEMA.ROCKSDB_COMPACTION_STATS properly * Check the output of the command: ``` mysql> show status like 'rocksdb_stall_%'; +-----------------------------------------------------+-------+ | Variable_name | Value | +-----------------------------------------------------+-------+ | rocksdb_stall_level0_slowdown | 2 | | rocksdb_stall_level0_slowdown_with_compaction | 4 | | rocksdb_stall_level0_numfiles | 10 | | rocksdb_stall_level0_numfiles_with_compaction | 12 | | rocksdb_stall_stop_for_pending_compaction_bytes | 16 | | rocksdb_stall_slowdown_for_pending_compaction_bytes | 14 | | rocksdb_stall_memtable_compaction | 6 | | rocksdb_stall_memtable_slowdown | 8 | | rocksdb_stall_total_count | 56 | | rocksdb_stall_micros | 0 | +-----------------------------------------------------+-------+ ``` (In order to have some non-zero numbers, I've initialized internal RocksDB stall stats with 1-8 numbers. They all doubled in output as there are two column families in my instance: default and system. The stall_micros has been introduced previously. total_count doesn't include level0_slowdown_with_compaction and numfiles_with_compaction as only their total counterparts are included in this counter.) Differential Revision: D5723305 Pulled By: Tema fbshipit-source-id: 197733836ef
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Feb 24, 2021
Summary: update-submodule: rocksdb The stall counters are already shown in 'SHOW ENGINE ROCKSDB STATUS output' but this command is a bit expensive to run and you have to parse the output to monitor these values. This branch adds these counters to structured output of SHOW GLOBAL STATUS command. Also fixed the bug in INFORMATION_SCHEMA.ROCKSDB_COMPACTION_STATS which showed only integer values but not float. The rocksdb module was updated to bring [this](facebook/rocksdb#2794 (review)) change which has the following changes to GetMapProperty method: 1. Changed values from double to string 2. Change existing keys to start with "compaction." prefix for all keys returned by old version of GetMapProperty. 3. Added stall values with keys starting with "io_stall." prefix Closes facebook/mysql-5.6#695 Test Plan: * Check that compaction level metrics are still published to INFORMATION_SCHEMA.ROCKSDB_COMPACTION_STATS properly * Check the output of the command: ``` mysql> show status like 'rocksdb_stall_%'; +-----------------------------------------------------+-------+ | Variable_name | Value | +-----------------------------------------------------+-------+ | rocksdb_stall_level0_slowdown | 2 | | rocksdb_stall_level0_slowdown_with_compaction | 4 | | rocksdb_stall_level0_numfiles | 10 | | rocksdb_stall_level0_numfiles_with_compaction | 12 | | rocksdb_stall_stop_for_pending_compaction_bytes | 16 | | rocksdb_stall_slowdown_for_pending_compaction_bytes | 14 | | rocksdb_stall_memtable_compaction | 6 | | rocksdb_stall_memtable_slowdown | 8 | | rocksdb_stall_total_count | 56 | | rocksdb_stall_micros | 0 | +-----------------------------------------------------+-------+ ``` (In order to have some non-zero numbers, I've initialized internal RocksDB stall stats with 1-8 numbers. They all doubled in output as there are two column families in my instance: default and system. The stall_micros has been introduced previously. total_count doesn't include level0_slowdown_with_compaction and numfiles_with_compaction as only their total counterparts are included in this counter.) Differential Revision: D5723305 Pulled By: Tema fbshipit-source-id: 197733836ef
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Nov 15, 2021
…cona#695) Summary: update-submodule: rocksdb The stall counters are already shown in 'SHOW ENGINE ROCKSDB STATUS output' but this command is a bit expensive to run and you have to parse the output to monitor these values. This branch adds these counters to structured output of SHOW GLOBAL STATUS command. Also fixed the bug in INFORMATION_SCHEMA.ROCKSDB_COMPACTION_STATS which showed only integer values but not float. The rocksdb module was updated to bring [this](facebook/rocksdb#2794 (review)) change which has the following changes to GetMapProperty method: 1. Changed values from double to string 2. Change existing keys to start with "compaction." prefix for all keys returned by old version of GetMapProperty. 3. Added stall values with keys starting with "io_stall." prefix Closes facebook/mysql-5.6#695 Differential Revision: D5723305 (facebook/mysql-5.6@3f9ff43) Pulled By: Tema fbshipit-source-id: 688fb48f15f
ldonoso
pushed a commit
to ldonoso/percona-server
that referenced
this pull request
Mar 15, 2022
…cona#695) Summary: @update-submodule: rocksdb The stall counters are already shown in 'SHOW ENGINE ROCKSDB STATUS output' but this command is a bit expensive to run and you have to parse the output to monitor these values. This branch adds these counters to structured output of SHOW GLOBAL STATUS command. Also fixed the bug in INFORMATION_SCHEMA.ROCKSDB_COMPACTION_STATS which showed only integer values but not float. The rocksdb module was updated to bring [this](facebook/rocksdb#2794 (review)) change which has the following changes to GetMapProperty method: 1. Changed values from double to string 2. Change existing keys to start with "compaction." prefix for all keys returned by old version of GetMapProperty. 3. Added stall values with keys starting with "io_stall." prefix Closes facebook/mysql-5.6#695 Differential Revision: D5723305 Pulled By: Tema
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Apr 9, 2024
…cona#695) Summary: @update-submodule: rocksdb The stall counters are already shown in 'SHOW ENGINE ROCKSDB STATUS output' but this command is a bit expensive to run and you have to parse the output to monitor these values. This branch adds these counters to structured output of SHOW GLOBAL STATUS command. Also fixed the bug in INFORMATION_SCHEMA.ROCKSDB_COMPACTION_STATS which showed only integer values but not float. The rocksdb module was updated to bring [this](facebook/rocksdb#2794 (review)) change which has the following changes to GetMapProperty method: 1. Changed values from double to string 2. Change existing keys to start with "compaction." prefix for all keys returned by old version of GetMapProperty. 3. Added stall values with keys starting with "io_stall." prefix Closes facebook/mysql-5.6#695 Differential Revision: D5723305 Pulled By: Tema
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ton: _use_count != 0 ' failed (errno=0)