Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug 1606478 (rpl.rpl_extra_col_master_myisam test unstable on 5.5) #700

Merged
merged 1 commit into from Jul 26, 2016

Conversation

laurynas-biveinis
Copy link
Contributor

rpl_extra_col_master_myisam test fails on 5.5 with

rpl.rpl_extra_col_master_myisam 'row' w4 [ fail ] Found warnings/errors in server log file!
...
160719 21:13:07 [Warning] Slave I/O: SET @master_heartbeat_period to master failed with error: Lost connection to MySQL server during query, Error_code: 2013
...
^ Found warnings in /mnt/workspace/percona-server-5.5-trunk/BUILD_TYPE/debug/Host/ubuntu-precise-64bit/mysql-test/var/4/log/mysqld.2.err
...

The likely cause is the test doing

START SLAVE;

followed almost immediately by

STOP SLAVE;

as START SLAVE is async command, it might not be fully completed by
the time STOP SLAVE comes, getting killed by it, and resulting in the
above warning.

Fix by partially backporting [1], which uses rpl_reset.inc, which
waits synchronously for START SLAVE to complete.

[1]:

commit 82320f9
Author: Sven Sandberg sven.sandberg@oracle.com
Date: Mon Dec 19 11:41:54 2011 +0100

WL#3584 bugfixes
 - bugfix: reset slave should not reset Gtid_state
 - bugfix: always register binlog handler when acquiring ownership of
   GTIDs, so that ownership can be released
 - bugfix: write empty GTID to binary log when releasing ownership of
   GTIDs, if GTID is not already in binary log
 - bugfix: don't acquire ownership for empty statements
 - feature: added @@global.gtid_owned and @@session.gtid_owned
 - cleanup: don't pass gtid_state, global_sid_lock, or global_sid_map as arguments
   in functions in Group_cache, and zgroup_execution.cc
 - cleanup: pass Gtid instead of (rpl_sidno, rpl_gno) to some
   functions
 - cleanup: moved Group_cache::update_gtid_state to Gtid_state::update
 - extra assertions
 - clean up some comments
 - disable use of gtid_next_list until we need it
 - clean up some tests

http://jenkins.percona.com/job/percona-server-5.5-param/1263/

rpl_extra_col_master_myisam test fails on 5.5 with

rpl.rpl_extra_col_master_myisam 'row' w4 [ fail ] Found warnings/errors in server log file!
...
160719 21:13:07 [Warning] Slave I/O: SET @master_heartbeat_period to master failed with error: Lost connection to MySQL server during query, Error_code: 2013
...
^ Found warnings in /mnt/workspace/percona-server-5.5-trunk/BUILD_TYPE/debug/Host/ubuntu-precise-64bit/mysql-test/var/4/log/mysqld.2.err
...

The likely cause is the test doing

START SLAVE;

followed almost immediately by

STOP SLAVE;

as START SLAVE is async command, it might not be fully completed by
the time STOP SLAVE comes, getting killed by it, and resulting in the
above warning.

Fix by partially backporting [1], which uses rpl_reset.inc, which
waits synchronously for START SLAVE to complete.

[1]:

commit 82320f9
Author: Sven Sandberg <sven.sandberg@oracle.com>
Date: Mon Dec 19 11:41:54 2011 +0100

    WL#3584 bugfixes
     - bugfix: reset slave should not reset Gtid_state
     - bugfix: always register binlog handler when acquiring ownership of
       GTIDs, so that ownership can be released
     - bugfix: write empty GTID to binary log when releasing ownership of
       GTIDs, if GTID is not already in binary log
     - bugfix: don't acquire ownership for empty statements
     - feature: added @@global.gtid_owned and @@session.gtid_owned
     - cleanup: don't pass gtid_state, global_sid_lock, or global_sid_map as arguments
       in functions in Group_cache, and zgroup_execution.cc
     - cleanup: pass Gtid instead of (rpl_sidno, rpl_gno) to some
       functions
     - cleanup: moved Group_cache::update_gtid_state to Gtid_state::update
     - extra assertions
     - clean up some comments
     - disable use of gtid_next_list until we need it
     - clean up some tests
@percona-ysorokin
Copy link
Collaborator

LGTM

@laurynas-biveinis laurynas-biveinis merged commit ea600d6 into percona:5.5 Jul 26, 2016
@laurynas-biveinis laurynas-biveinis deleted the bug1606478-5.5 branch July 26, 2016 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants