Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug 1100652 (innochecksum always fail to check table files with #77

Merged
merged 1 commit into from May 20, 2015

Conversation

laurynas-biveinis
Copy link
Contributor

KEY_BLOCK_SIZE=4 and ROW_FORMAT=COMPRESSED).

Implement compressed table support for innochecksum by adapting a
similar patch from Facebook MySQL 5.1 at
http://bazaar.launchpad.net/~mysqlatfacebook/mysqlatfacebook/5.1/revision/3813,
and by selective backport of MySQL 5.7 innochecksum MTR tests
(WL #6045).

Changes from the Facebook patch:

  • -b option was not added;
  • --innodb-fast-checksum support was not added;
  • support for different uncompressed InnoDB page sizes was not added;
  • compilation warnings have been fixed and other minor code cleanups
    done;
  • the display of the detected compression and page size has been
    conditional on -f option not being present, which would print the
    same information again.

http://jenkins.percona.com/job/percona-server-5.5-param/1105/
Also did some local runs with innochecksum debug output enabled.

KEY_BLOCK_SIZE=4 and ROW_FORMAT=COMPRESSED).

Implement compressed table support for innochecksum by adapting a
similar patch from Facebook MySQL 5.1 at
http://bazaar.launchpad.net/~mysqlatfacebook/mysqlatfacebook/5.1/revision/3813,
and by selective backport of MySQL 5.7 innochecksum MTR tests
(WL #6045).

Changes from the Facebook patch:
- -b option was not added;
- --innodb-fast-checksum support was not added;
- support for different uncompressed InnoDB page sizes was not added;
- compilation warnings have been fixed and other minor code cleanups
  done;
- the display of the detected compression and page size has been
  conditional on -f option not being present, which would print the
  same information again.
@laurynas-biveinis
Copy link
Contributor Author

ST 43131

vlad-lesin pushed a commit that referenced this pull request May 20, 2015
Fix bug 1100652 (innochecksum always fail to check table files with
@vlad-lesin vlad-lesin merged commit ce348fe into percona:5.5 May 20, 2015
@laurynas-biveinis laurynas-biveinis deleted the bug1100652-5.5 branch May 21, 2015 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants