Bug1609364 5.7 #771
Merged
Bug1609364 5.7 #771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rge with innodb_fast_shutdown=0) The separate purge thread loop exits immediately on any srv_shutdown_state > 0 value even though it's supposed to keep on purging if srv_fast_shutdown == 0. Fix by - signalling the purge thread to wake up at the start of logs_empty_and_mark_files_at_shutdown; - adjusting the purge thread suspend condition so that it's never suspended during shutdown; - adjusting the purge thread loop break condition to exit the loop immediately if we are at fast shutdown, or if we are at the slow shutdown and the last TRX_SYS_N_RSEGS attempts to purge did nothing; - reverting what looks the previous attempt to fix this, which caused master thread to do purging even with separate purge thread enabled, but was racy; This also fixes bug 756387.
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Apr 23, 2020
… of -1. (percona#771) Summary: New behavior for rocksdb_max_open_files is as such : * -1 : infinite, pass -1 to rocksdb * 0 : 'auto-tune', silently set rocksdb_max_open_files to 1/2 of mysql open_files_limit * > 0 <= open_files_limit : take value as-is * > open_files_lmit : set rocksdb_max_open_files to 1/2 of mysql open_files_limit and emit a warning to the mysqld error log. Closes facebook/mysql-5.6#771 Reviewed By: Tema Differential Revision: D6569611 Pulled By: Tema fbshipit-source-id: e4b28e3fe1c
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Feb 24, 2021
… of -1. (percona#771) Summary: New behavior for rocksdb_max_open_files is as such : * -1 : infinite, pass -1 to rocksdb * 0 : 'auto-tune', silently set rocksdb_max_open_files to 1/2 of mysql open_files_limit * > 0 <= open_files_limit : take value as-is * > open_files_lmit : set rocksdb_max_open_files to 1/2 of mysql open_files_limit and emit a warning to the mysqld error log. Closes facebook/mysql-5.6#771 Reviewed By: Tema Differential Revision: D6569611 Pulled By: Tema fbshipit-source-id: e4b28e3fe1c
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Nov 15, 2021
… of -1. (percona#771) (percona#771) Summary: New behavior for rocksdb_max_open_files is as such : * -1 : infinite, pass -1 to rocksdb * 0 : 'auto-tune', silently set rocksdb_max_open_files to 1/2 of mysql open_files_limit * > 0 <= open_files_limit : take value as-is * > open_files_lmit : set rocksdb_max_open_files to 1/2 of mysql open_files_limit and emit a warning to the mysqld error log. Closes facebook/mysql-5.6#771 Differential Revision: D6569611 (facebook/mysql-5.6@9c11830) Pulled By: Tema fbshipit-source-id: d4f3c1ef469
ldonoso
pushed a commit
to ldonoso/percona-server
that referenced
this pull request
Mar 15, 2022
… of -1. (percona#771) (percona#771) Summary: New behavior for rocksdb_max_open_files is as such : * -1 : infinite, pass -1 to rocksdb * 0 : 'auto-tune', silently set rocksdb_max_open_files to 1/2 of mysql open_files_limit * > 0 <= open_files_limit : take value as-is * > open_files_lmit : set rocksdb_max_open_files to 1/2 of mysql open_files_limit and emit a warning to the mysqld error log. Closes facebook/mysql-5.6#771 Differential Revision: D6569611 Pulled By: Tema
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Apr 9, 2024
… of -1. (percona#771) (percona#771) Summary: New behavior for rocksdb_max_open_files is as such : * -1 : infinite, pass -1 to rocksdb * 0 : 'auto-tune', silently set rocksdb_max_open_files to 1/2 of mysql open_files_limit * > 0 <= open_files_limit : take value as-is * > open_files_lmit : set rocksdb_max_open_files to 1/2 of mysql open_files_limit and emit a warning to the mysqld error log. Closes facebook/mysql-5.6#771 Differential Revision: D6569611 Pulled By: Tema
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.