Fix bug 1609422 (Unit test lf-t unstable) #776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjust lf-t test threads so that they call my_thread_end before signalling the main thread that test is done, in order to avoid race on with_my_thread_init flag, which would cause my_thread_init/my_thread_end mismatch. Remove obsolete "sleep(2)" from the test framework.
|
the comment is awesome |
|
The comment is referring to https://bugs.mysql.com/bug.php?id=22320, which boils down to that it's impossible to wrap CMPXCHG8B in GCC inline asm :), not a problem if GCC atomic builtins are available |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust lf-t test threads so that they call my_thread_end before
signalling the main thread that test is done, in order to avoid race
on with_my_thread_init flag, which would cause
my_thread_init/my_thread_end mismatch. Remove obsolete "sleep(2)" from
the test framework.
http://jenkins.percona.com/job/percona-server-5.5-param/1303/