Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra word 'default' from the --verbose help, it was confusing the option parser #123

Merged
merged 1 commit into from Aug 2, 2016

Conversation

sodabrew
Copy link
Contributor

@sodabrew sodabrew commented Aug 1, 2016

No description provided.

@sodabrew sodabrew force-pushed the patch-3 branch 2 times, most recently from 5625a47 to 10f7d32 Compare August 1, 2016 21:49
@sodabrew sodabrew changed the title Fix pt-slave-restart verbosity from quiet 0, to default 1, to verbose 2 and above Remove extra word 'default' from the --verbose help, it was confusing the option parser Aug 1, 2016
@sodabrew
Copy link
Contributor Author

sodabrew commented Aug 1, 2016

Current release version:

$ bin/pt-slave-restart --help | grep verbose
  --quiet            -q  Suppresses normal output (disables --verbose)
  --verbose          -v  Adds more information to the default output (default 1)
  --verbose              output (default 1

Note that the default value for --verbose is not an integer, which causes any code that compares $o->get('verbose') against another integer to fail when --verbose or --quiet are not specified (in other words, it fails by default).

With this fix:

$ bin/pt-slave-restart --help | grep verbose
  --quiet            -q  Suppresses normal output (disables --verbose)
  --verbose          -v  Adds more information to the output (default 1)
  --verbose              1

@percona-csalguero
Copy link
Contributor

Thanks for this fix @sodabrew

@percona-csalguero percona-csalguero merged commit 6859daf into percona:2.2 Aug 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants