Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pt-osc: Fails with duplicate key in table for self-referencing FK #137

Merged
merged 5 commits into from Jan 16, 2017
Merged

pt-osc: Fails with duplicate key in table for self-referencing FK #137

merged 5 commits into from Jan 16, 2017

Conversation

amielz
Copy link
Contributor

@amielz amielz commented Oct 12, 2016

pt-online-schema-change fails with duplicate key in table for self-referencing FK
https://bugs.launchpad.net/percona-toolkit/+bug/1632522

@percona-csalguero
Copy link
Contributor

Could you add a test case?

@amielz
Copy link
Contributor Author

amielz commented Oct 13, 2016

Stupid question... Can you please point me to some doc on how to setup the test environment so I can run the new test I'm creating?

@percona-csalguero
Copy link
Contributor

Oh, yes, sorry. Tomorrow I am going to add a document to the repo explaining how to set up the environment.
Thanks for you help and patience.

@amielz
Copy link
Contributor Author

amielz commented Oct 14, 2016 •
edited

Cool, looking forward to setting up the test env. Also from the docs

DROP FOREIGN KEY constraint_name requires specifying _constraint_name rather than the real

What if the tool looks up the real constraint name from the new table? This would be ideal as it will be transparent to the users.

@percona-csalguero
Copy link
Contributor

Hi.
I've added explanations here: https://github.com/percona/percona-toolkit/blob/2.2/CONTRIBUTE.md#setting-up-the-development-environment
Please let me know if you need something else.
Regards

@amielz
Merge branch '2.2' into pt-osc-bug-1632522
cb535d2 
* 2.2:
  Small cosmetic fix to the docs
  Small cosmetic fix to the docs
  Small cosmetic fix to the docs
  Updated docs. How to set up the dev env
@amielz
Added tests for bug 1632522
5ea2f6b 
Adjusted renamt_fk_constraints.t for new renaming logic
@amielz
Copy link
Contributor Author

amielz commented Oct 15, 2016

OK, added the tests and made adjustment to existing rename_fk test.

@percona-csalguero
Copy link
Contributor

I ran the tests and everything looks good.
I need one more thing: could you add a comment saying the code provided is your own creation and it can be distributed under BSD licence, please?

@amielz
Copy link
Contributor Author

amielz commented Jan 16, 2017

I actually made one more change to compatibility with older Perl versions.

This is my own creation and it can be distributed under BSD license.

@percona-csalguero
Copy link
Contributor

Thanks @amiel-marqeta

@percona-csalguero percona-csalguero merged commit 046a5e9 into percona:2.2 Jan 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@amielz @percona-csalguero