PT-2114 Incorrect casting of bit columns by pt archiver #587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
svetasmirnova
commented
Feb 10, 2023
•
svetasmirnova
commented
- The contributed code is licensed under GPL v2.0
- Contributor Licence Agreement (CLA) is signed
- util/update-modules has been ran
- Documention updated
- Test suite update
Added special handling of BIT columns, because by default Perl does not properly recognizes this type and creates invalid query for MySQL. Removed debugging comment from t/pt-table-checksum/pt-226.t Added test case.
Removed debugging comments from t/pt-deadlock-logger/standard_options.t and t/pt-table-checksum/fnv_64.t
Added test for archiving BIT columns.
Added test for bulk operations
Added more tests for BIT columns
- Improved fix for PT-2123, so it works with 5.7 - Fixed tests for PT-2114, so they work with 5.7
EvgeniyPatlan
approved these changes
Feb 13, 2023
percona-csalguero
approved these changes
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.