Bug 1665239: -h shortcut seems to be not working for xtrabackup #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xtrabackup -h localhost
aborted with error message
xtrabackup: Error: unknown argument: 'localhost'
Here is why. -h is a shortcut for --datadir, which is server option
and 'localhost' was recognized as it's argument and handled
correctly.
Then xtrabackup was trying to pick client options and 'localhost'
option was marked as not handled.
Then xtrabackup checked options which were not handled during
previous step and complained that 'localhost' is incorrect.
Fix is to abort only in case when option was not recognized as client
option neither as server option.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aborted with error message
Here is why. -h is a shortcut for --datadir, which is server option
and 'localhost' was recognized as it's argument and handled
correctly.
Then xtrabackup was trying to pick client options and 'localhost'
option was marked as not handled.
Then xtrabackup checked options which were not handled during
previous step and complained that 'localhost' is incorrect.
Fix is to abort only in case when option was not recognized as client
option neither as server option.