Bug 1448447: Fix for bug 1403237 is incomplete (2.2) #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the end of the log copying process XtraBackup invokes log_group_read_checkpoint_info to grab latest checkpoint LSN which resets group->lsn_offset to wrong value. As the result last copied batch of log records is copied from wrong location. Fixed is following: 1. Remember if we chose to use alternative LSN offset location. 2. Allow to try different offset at any time, not only when reading the first log block. It handles the case when copying started with offset lower than 4G and finished with offset higher than 4G.
gl-sergei
changed the title
|
+1 |
gl-sergei
added a commit
that referenced
this pull request
May 11, 2015
Bug 1448447: Fix for bug 1403237 is incomplete (2.2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the end of the log copying process XtraBackup invokes
log_group_read_checkpoint_info to grab latest checkpoint LSN which
resets group->lsn_offset to wrong value. As the result last copied
batch of log records is copied from wrong location.
Fix is following:
reading the first log block. It handles the case when copying
started with offset lower than 4G and finished with offset
higher than 4G.
http://jenkins.percona.com/view/PXB%202.2/job/percona-xtrabackup-2.2-param/301/