Bug 1192834: disable compact backups in 2.4 #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were several issues with compact backups: 1. Prepare failed on rollback and purge phases because secondary indexes are not rebuilt by the time of rollback/purge. Fixed by skipping rollback and purge for all secondary indexes. 2. Pages in buffer pool could mistakenly be marked as compacted and redo log would not be replayed on such pages which led to corrupt backups and crashes. Fixed by clearing `is_compacted' for every page read into the buffer pool. 3. Compacted pages which have been freed up and repurposed by server were not fully reset during prepare which let to corrupt backups. 4. Index rebuild process could start in parallel with rollback phase which led to crashes and corrupt backups. Fix makes sure that index rebuild process isn't started until rollback is fully complete.
Disable compact backups in 2.4 * 2.3-xb-bug1192834: Bug 1192834: Crash during apply with index compaction enabled
|
|
||
| . inc/common.sh | ||
|
|
||
| skip_test "Enable when bug #1192834 is fixed in 2.4" |
There was a problem hiding this comment.
If I get it right, this PR would fix the 1192834. Should we enable this test now?
|
|
||
| . inc/common.sh | ||
|
|
||
| skip_test "Enable when bug #1192834 is fixed in 2.4" |
There was a problem hiding this comment.
Same here, enable test?
|
I was going to mark bug 1192834 as "Won't fix" in 2.4. But was to going to keep the tests in case if we change our mind. The bug will still be valid for 2.4 even though one will not be able to take compact backup with 2.4, he can take the backup using 2.3 and crash 2.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge test cases for bug 1192834, but disable them. Change
compact.shto check that--compactoption no longer available.